Skip to content

update bootstrapper.spec and engine.spec - #22

Merged
neyunse merged 1 commit into
devfrom
gh/neyunse/dev
Aug 4, 2025
Merged

update bootstrapper.spec and engine.spec#22
neyunse merged 1 commit into
devfrom
gh/neyunse/dev

Conversation

@neyunse

@neyunse neyunse commented Aug 4, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings August 4, 2025 03:43
@neyunse
neyunse merged commit 781079d into dev Aug 4, 2025
1 check was pending

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates PyInstaller specification files to disable console output for both the engine and bootstrapper executables. The change converts these applications from console-based to windowed applications.

  • Changes console=True to console=False in both spec files
  • Affects the runtime behavior of the generated executables

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
engine.spec Disables console window for the engine executable
bootstrapper.spec Disables console window for the bootstrapper executable

Comment thread engine.spec
upx_exclude=[],
runtime_tmpdir=None,
console=True,
console=False,

Copilot AI Aug 4, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting console=False will suppress all console output including error messages and debug information. Consider the impact on debugging and error reporting before deploying to production.

Suggested change
console=False,
console=True,

Copilot uses AI. Check for mistakes.
Comment thread bootstrapper.spec
upx_exclude=[],
runtime_tmpdir=None,
console=True,
console=False,

Copilot AI Aug 4, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting console=False will suppress all console output including error messages and debug information. Consider the impact on debugging and error reporting before deploying to production.

Suggested change
console=False,
console=True,

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants