Reset Note Texture Colors - #1392
Conversation
There was a problem hiding this comment.
The editor changes the color of the note textures when displaying golden notes, but the sing screen doesn't.
Why is the editor even touching them at all in the first place? Do we really need golden notes to be hardcoded green for some reason? I swear if the answer contains the acronym "CMD"... It could be that it has to do with whether... whatever is the setting that controls whether you get the golden sparkle thingies or not is enabled, but that then just raises even more questions (like, how does regular singing look then? Why is this even a setting in the first place? I swear if the answer contains "party mode"...)
As for this PR: can reproduce and will obviously merge for the short-term, though longer-term we should probably think about:
- the editor doesn't touch the textures at all (idk if possible with the highlighting)
- this has to do with the golden sprinkle setting, but then why is it green if sprinkles are on
- the editor has its own set of textures
This fixes a minor regression introduced in #1296 where the color of the sung note textures can be wrong on the sing screen in an edge case (see screenshot). To reproduce:
The editor and sing screen share the same note textures. The editor changes the color of the note textures when displaying golden notes, but the sing screen doesn't. This new code resets the color of the texture so it's not affected by the changes the editor makes to it.