Skip to content

Reset Note Texture Colors - #1392

Merged
barbeque-squared merged 1 commit into
masterfrom
note-color
Aug 13, 2026
Merged

Reset Note Texture Colors#1392
barbeque-squared merged 1 commit into
masterfrom
note-color

Conversation

@complexlogic

@complexlogic complexlogic commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

This fixes a minor regression introduced in #1296 where the color of the sung note textures can be wrong on the sing screen in an edge case (see screenshot). To reproduce:

  1. Open a song in the editor
  2. Go to a line where the last note in the line is a golden note
  3. Exit the editor and immediately play the song in regular sing mode.

The editor and sing screen share the same note textures. The editor changes the color of the note textures when displaying golden notes, but the sing screen doesn't. This new code resets the color of the texture so it's not affected by the changes the editor makes to it.

screen

@barbeque-squared barbeque-squared left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The editor changes the color of the note textures when displaying golden notes, but the sing screen doesn't.

Why is the editor even touching them at all in the first place? Do we really need golden notes to be hardcoded green for some reason? I swear if the answer contains the acronym "CMD"... It could be that it has to do with whether... whatever is the setting that controls whether you get the golden sparkle thingies or not is enabled, but that then just raises even more questions (like, how does regular singing look then? Why is this even a setting in the first place? I swear if the answer contains "party mode"...)

As for this PR: can reproduce and will obviously merge for the short-term, though longer-term we should probably think about:

  • the editor doesn't touch the textures at all (idk if possible with the highlighting)
  • this has to do with the golden sprinkle setting, but then why is it green if sprinkles are on
  • the editor has its own set of textures

@barbeque-squared
barbeque-squared merged commit 1591d4b into master Aug 13, 2026
8 of 9 checks passed
@barbeque-squared
barbeque-squared deleted the note-color branch August 13, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants