Fix uninitialized avatar load result (#1296 regression) - #1373
Merged
complexlogic merged 1 commit intoAug 2, 2026
Conversation
complexlogic
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #1296 was merged,
TAvatarDatabase.LoadAvatarassigns its class-valuedResultonly inside atryblock. If the database query or a field conversion raises first, the exception is logged and the function returns without an explicit result. A class variable is a reference; declaring it does not construct an object. See the Free Pascal class-instantiation documentation.Fix
Initialize
Result := nilbefore entering the failure-prone block. This is a one-line change and preserves every successful return path.Reproduce/verify
Make the avatar query fail (for example, temporarily request a missing/corrupt thumbnail row) and call
LoadAvatar. Before the fix the returned reference is not defined by the function; after it the failure contract is deterministicallynil. Tested on Windows 11.