Skip to content
This repository was archived by the owner on Jul 9, 2019. It is now read-only.

docker build is failure in lint step#31

Open
Mizuki Urushida (zuiurs) wants to merge 1 commit into
Ultimaker:masterfrom
zuiurs:fix_flake8_warning
Open

docker build is failure in lint step#31
Mizuki Urushida (zuiurs) wants to merge 1 commit into
Ultimaker:masterfrom
zuiurs:fix_flake8_warning

Conversation

@zuiurs

Copy link
Copy Markdown

what's happend

In processing Dockerfile, the step of flake8 check was failure.

$ docker build --tag ultimaker/k8s-mongo-operator:local .
<output omitted>

Step 15/21 : RUN flake8 . --count
 ---> Running in a6c3775ae6e1
./tests/services/TestMongoService.py:119:31: Q003 Change outer quotes to avoid escaping inner quotes
./tests/services/TestMongoService.py:190:13: Q003 Change outer quotes to avoid escaping inner quotes
./tests/services/TestMongoService.py:206:13: Q003 Change outer quotes to avoid escaping inner quotes
./tests/services/TestMongoService.py:211:26: Q003 Change outer quotes to avoid escaping inner quotes
4
The command '/bin/sh -c flake8 . --count' returned a non-zero code: 1

what this PR does

replace double quotes to single quotes in some line where includes back slash for escaping innner quotes.

@ChrisTerBeke Chris ter Beke (ChrisTerBeke) added the enhancement New feature or request label Jul 4, 2019
@ChrisTerBeke Chris ter Beke (ChrisTerBeke) removed their assignment Jul 9, 2019
@ChrisTerBeke Chris ter Beke (ChrisTerBeke) removed the enhancement New feature or request label Jul 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants