Skip to content

Update printer linter to utilize the reusable action #21657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
HellAholic wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update printer linter to utilize the reusable action #21657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions .github/workflows/printer-linter-pr-diagnose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,27 @@ jobs:
- name: Setup the build environment
uses: ultimaker/cura-workflows/.github/actions/setup-build-environment@main

- uses: greguintow/get-diff-action@v7
- id: get-diff
uses: ultimaker/cura-workflows/.github/actions/get-diff@main
with:
DIFF_FILTER: AMRCD
PATTERNS: |
resources/+(extruders|definitions)/*.def.json
resources/+(intent|quality|variants)/**/*.inst.cfg
files: |
resources/extruders/*.def.json
resources/definitions/*.def.json
resources/intent/**/*.inst.cfg
resources/quality/**/*.inst.cfg
resources/variants/**/*.inst.cfg
include_deleted: 'true'

- name: Create results directory
run: mkdir printer-linter-result

- name: Diagnose file(s)
if: env.GIT_DIFF && !env.MATCHED_FILES
run: python printer-linter/src/terminal.py --diagnose --report printer-linter-result/fixes.yml ${{ env.GIT_DIFF_FILTERED }}
if: steps.get-diff.outputs.files != ''
run: python printer-linter/src/terminal.py --diagnose --report printer-linter-result/fixes.yml ${{ steps.get-diff.outputs.files_quoted }}

- name: Check Deleted Files(s)
if: env.GIT_DIFF
run: python printer-linter/src/terminal.py --deleted --report printer-linter-result/comment.md ${{ env.GIT_DIFF_FILTERED }}
if: steps.get-diff.outputs.files != ''
run: python printer-linter/src/terminal.py --deleted --report printer-linter-result/comment.md ${{ steps.get-diff.outputs.files_quoted }}

- name: Save PR metadata
run: |
Expand Down