fix: sysprocattr option - #157
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where Scanner’s WithCustomSysProcAttr callback could not modify the underlying exec.Cmd.SysProcAttr because it was nil by default. The change ensures the struct is initialized before invoking the user-provided modifier function, and adds a regression test to prevent regressions.
Changes:
- Initialize
cmd.SysProcAttrto&syscall.SysProcAttr{}before callingmodifySysProcAttr. - Add a regression test asserting the callback receives (and can mutate) the same
SysProcAttrpointer stored on the command. - Fix a minor typo in the
Scannertype comment.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nmap.go | Fixes a typo in the Scanner doc comment. |
| helpers.go | Ensures exec.Cmd.SysProcAttr is non-nil before invoking WithCustomSysProcAttr callback. |
| helpers_test.go | Adds regression coverage validating initialization and pointer identity for SysProcAttr. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Fixes #155
Creates an empty struct before calling
modifySysProcAttr.Thanks to @roysmanfo for the bug report.
How did I test it