Conversation
* Fixes warnings being overwritten in processResult * Fixes finalizeRun incorrectly returning * Update README async example * Improve multiple examples * Remove unused error sentinel * Call os.Exit in TestMain
PSAThis branch despite not being merged, is already used by the latest (pre-release) v6.0.0 of Cameradar. I will consider this PR a blocker for Cameradar to get out of pre-release and get an official v6 release. I am hoping to get some human reviews on this PR, but if by the end of February 2026 it does not, I will give it a few double checks myself and go ahead :) |
|
Seems good to me. Working in my local app I use it for and loving the simplicity. |
TerminalFi
left a comment
There was a problem hiding this comment.
Generally speaking good stuff! Could simplify 60% or so of the appends since append accepts multiple args / slice. This would just shorten code but not much else.
|
@TerminalFi Fixed all occurrences of unnecessary double appends, and actually while doing so I realized the
So now I switched it to using string values, since those are not susceptible to this bug. They make the readability of the args arguably worse when lots of flags are provided/better when less are provided, but anyway there's no way around it without opening a PR against Thanks so much for your review 🙏 |
Goal of this PR
Refactors the library into a v4 API with clearer sync/async execution paths, improved context propagation, progress streaming, and expanded examples/tests (including Docker-based compatibility tests).
Changes
How to test it
nmapanddockerinstalled.Then,
make lintmake fmtmake testNotes
Fixes #128
Closes #31 — Implementation is now completely different.
Closes #113 — Seemingly already fixed, but need to confirm with involved parties that default value is OK.