Skip to content

Tetra Star-ID algorithm#91

Open
zeddie888 wants to merge 108 commits into
masterfrom
ezhang8-tetra2
Open

Tetra Star-ID algorithm#91
zeddie888 wants to merge 108 commits into
masterfrom
ezhang8-tetra2

Conversation

@zeddie888

Copy link
Copy Markdown
Collaborator

No description provided.

@markasoftware markasoftware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, all new command-line options must be documented in man pages

@markasoftware

Copy link
Copy Markdown
Member

Another comment: No debug info (like "Tetra max angle: XX" or "Found XXX Patterns") should be outputted to std::cout, only to std::cerr, because otherwise if someone tries to use output redirection to save the database (eg ./lost database --tetra > tetra.dat, which should work), it will also save the debug messages and corrupt the database.

@zeddie888

Copy link
Copy Markdown
Collaborator Author

@markasoftware Do you want to take another look at this PR? Newest commits allow Tetra to work nicely with the master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants