iDSpeedy Pull Request #1#33
Open
abelph wants to merge 8 commits into
Open
Conversation
…lls detector execution based on triedAllOrders
Tracking orders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit contains logic that sees whether the total number of test orders for a Detector class have been run. The triedAllOrders() method takes in an int representing the number of rounds run and will return a boolean indicating whether all possible test orders have been tried. triedAllOrders() has been added to ExecutingDetector.java as an abstract method.
Additional small changes were made to the code to retain the same style as the rest of the project.