feat: lab06#14
Merged
Merged
Conversation
Signed-off-by: Eva Cosma <eva.cosma.mail@gmail.com>
Contributor
Author
genan2003
reviewed
Apr 8, 2026
Collaborator
|
For me is looking good, but I think it would be nice to add more comments with explanations. |
alexandruradovici
previously requested changes
Apr 8, 2026
alexandruradovici
left a comment
alexandruradovici
left a comment
Contributor
There was a problem hiding this comment.
Please add comments that are similar to the ones from lab05.
Signed-off-by: Eva Cosma <eva.cosma.mail@gmail.com>
alexandruradovici
left a comment
alexandruradovici
left a comment
Contributor
There was a problem hiding this comment.
I would like us to follow the example from spi and actually write a driver for this device. Would that be possible?
genan2003
approved these changes
May 4, 2026
genan2003
dismissed
alexandruradovici’s stale review
Let the solution without a module for the sensor for now. We should look over them again at some point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request adds lab06 solutions
Testing Strategy
This pull request was tested by on the PM Board
TODO or Help Wanted
This pull request l-am facut pe repede inainte. Un double-check / un look-over sa fie facut mai clean ar fi necesar.
Build
cargo fmt.cargo build.cargo clippy.Author
Signed-off-by: Eva Cosma eva.cosma.mail@gmail.com