Review A: Add REVIEW.md — code review findings - #16
Open
davidpomerenke wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
REVIEW.mdwith a comprehensive code review of the current codebase.Key findings
Critical security issues:
POST /api/export/entitieshas no authentication check — any unauthenticated internet user can download a formatted Excel export/api/entity-confirmations) has noconfirmed_by_user_idfilter — any user of entity X can delete confirmations created by other users of entity XisQuerySafe()insrc/lib/chat-tools.tsuses\bpg_\bregex which never matches (underscore is a word character) —pg_read_fileetc. pass throughreadDocument()insrc/lib/chat-tools.tsuses the main admin DB pool instead of the restrictedchatQueryconnectionsql/auth_tables.sqlis out of sync: still definesrolecolumn dropped by migration 007;admin_emailstable missingDocumentation gaps:
DATABASE_URL_CHATenv var referenced in code but not in any env templateTest plan
/api/export/entitiesrequires no auth (curl without cookie)confirmed_by_user_idisQuerySafe('SELECT pg_read_file(...)')returnstrue(should befalse)🤖 Generated with Claude Code
Generated by Claude Code