support for drawer group management#582
Merged
Merged
Conversation
to avoid repeating explanation
There was a problem hiding this comment.
Pull request overview
Adds a feature-flagged “Drawer Management” area that lets eligible users view/manage drawers and manage drawer-sharing groups, reusing existing permissions/group concepts and TanStack Query patterns.
Changes:
- Introduces a new
/drawers/managepage with tabbed UI (Drawers / Rules / Groups) behindVITE_FEATURE_DRAWER_MANAGEMENT. - Adds drawer-permissions fetchers + queries + table UIs for listing manageable drawers and drawer permission groups (create/edit/delete).
- Refactors TanStack Query key construction in admin-permissions code via a shared
makeQueryKeysForhelper.
Reviewed changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/types/PermissionsTypes.ts | Extends permissions/group types for drawer group management (and adds ManageableDrawer). |
| src/types/index.ts | Adds features.drawerManagement to AppConfig. |
| src/router.ts | Registers the new /drawers/manage route behind the feature flag and permission gate. |
| src/pages/LogoutPage/LogoutPage.vue | Updates logout flow to tolerate dev-proxy redirect/network behavior. |
| src/pages/DrawerManagementPage/RulesTabContent.vue | Adds placeholder “Rules” tab content. |
| src/pages/DrawerManagementPage/GroupsTableColumns.tsx | Defines table columns (incl. actions) for drawer groups listing. |
| src/pages/DrawerManagementPage/GroupsTabContent.vue | Implements drawer groups list UI + create/edit modal + delete confirm flow. |
| src/pages/DrawerManagementPage/GroupFormModal.vue | Adds create/edit group modal for drawer groups. |
| src/pages/DrawerManagementPage/DrawersTableColumns.tsx | Defines columns for manageable drawers table. |
| src/pages/DrawerManagementPage/DrawersTabContent.vue | Implements manageable drawers list UI with filtering/sorting. |
| src/pages/DrawerManagementPage/DrawerManagementPage.vue | Adds the Drawer Management page shell with tab routing via query param. |
| src/pages/DrawerManagementPage/drawerGroupQueries.ts | Adds TanStack Query query/mutation wrappers for drawer group management. |
| src/pages/AllDrawersPage/AllDrawersPage.vue | Adds “Manage Drawers” entry point when feature flag is enabled. |
| src/pages/AdminPermissionsPage/ruleQueries.ts | Switches rule query keys to use the shared key helper. |
| src/pages/AdminPermissionsPage/GroupsTabContent.vue | Removes duplicated helper functions now provided in shared types. |
| src/pages/AdminPermissionsPage/groupQueries.ts | Switches group query keys to use the shared key helper. |
| src/pages/AdminPermissionsPage/GroupMembersTable.vue | Removes duplicate slot placement comment/markup in table template. |
| src/pages/AdminPermissionsPage/GroupFormModal.vue | Aligns create-group payload with updated CreateGroupPayload type. |
| src/helpers/makeQueryKeysFor.ts | Introduces reusable list/item query-key helper. |
| src/config.ts | Adds drawerManagement feature flag wiring from import.meta.env. |
| src/components/AppMenu/AppMenu.vue | Adds “Manage Drawers” nav item behind feature + permission gates. |
| src/api/fetchers.ts | Adds drawer-permissions endpoints + adjusts logout + group-create payload behavior. |
| bin/deploy-dev.sh | Enables the new feature flag in generated .env for dev deploys. |
| .env.example | Documents the new VITE_FEATURE_DRAWER_MANAGEMENT flag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jxjj
marked this pull request as ready for review
July 10, 2026 23:16
cmcfadden
approved these changes
Jul 11, 2026
jxjj
added a commit
that referenced
this pull request
Jul 14, 2026
* develop: support for drawer group management (#582)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds initial support for drawer permissions and group management. Behind a feature flag .env variable (
VITE_FEATURE_DRAWER_MANAGEMENT).No group member or entries management as part of this yet.
Also, my heuristic for identifying which group is a personal drawer group isn't quite right (at least in my case, where a group was created with me as a member before I created my first drawer).
On dev.