Set ComputerName for ComposeVApp - #17
Open
harmjanblok wants to merge 3 commits into
Open
Conversation
harmjanblok
changed the title
ComposeVApp
harmjanblok
force-pushed
the
computer-name
branch
from
February 15, 2018 13:40
ca1a0c7 to
3862117
Compare
|
Do you think it might be worth adding some name validation here? I believe the computer name attribute needs to conform to NETBIOS naming conventions whereas the VM name is more freeform. Perhaps worth throwing a useful error if it is incorrect? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the 'Virtual Machine name' and 'Computer name' to the specified
name, so (when guest customizations are enabled) this will be the actual hostname.