fix: resolve web component enum properties as dropdowns via DataType - #380
Open
IlianaB wants to merge 1 commit into
Open
fix: resolve web component enum properties as dropdowns via DataType#380IlianaB wants to merge 1 commit into
IlianaB wants to merge 1 commit into
Conversation
Read enum values from the registered UI5 DataType (DataType.getType(type).getEnumValues()) instead of walking the global window namespace. The generated UI5 Web Components wrappers are AMD-only modules that register their enums as DataTypes without exposing them on the global namespace, so the previous _transformStringTypeToObject walk failed and enum properties rendered as plain text fields. The legacy global walk is kept as a fallback for runtimes without getEnumValues(). Also guards against calling getDefaultValue()/getEnumValues() on a null DataType lookup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read enum values from the registered UI5 DataType
(DataType.getType(type).getEnumValues()) instead of walking the global window namespace. The generated UI5 Web Components wrappers are AMD-only modules that register their enums as DataTypes without exposing them on the global namespace, so the previous _transformStringTypeToObject walk failed and enum properties rendered as plain text fields. The legacy global walk is kept as a fallback for runtimes without getEnumValues().
Also guards against calling getDefaultValue()/getEnumValues() on a null DataType lookup.