build: add support for llvm-ml in cross-compilation toolchains#1244
Open
500Byte wants to merge 1 commit into
Open
build: add support for llvm-ml in cross-compilation toolchains#1244500Byte wants to merge 1 commit into
500Byte wants to merge 1 commit into
Conversation
Updates the LLVM tool discovery logic to find llvm-ml and configures the xwin-clang toolchains to use it as the MASM assembler. This allows assembling proxy generator files during Linux-to-Windows cross-compilation.
Collaborator
|
This may be a good change, and it's simple so I can forgive the use of AI, though I'm not happy about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for
llvm-mlin the build system to improve cross-compilation toolchains.The Problem
When cross-compiling (especially for Linux or specific toolchains without native MSVC
ml64), the build system lacked explicit support for the LLVM macro assembler (llvm-ml), causing compilation failures or requiring manual build script hacks.The Solution
Updated the CMake/build configurations to explicitly support
llvm-mlas an assembler drop-in, enabling smooth cross-compilation with LLVM-based toolchains.