Milestone #3 Feedback

[rainerlempert]

Great work team! Your package installs easily and all of your tests pass! You did a great job documenting your tasks in issue trackers, and your functions contain solid documentation. A couple small notes:

• All of your tests passed, but there were 38 warning messages. I would recommend looking into this, and trying to reduce the number of warnings.
• I tried to run your tests a second time by calling devtools::test(). This time I received this error: "Loading miniTidyR
  Error in eval(exprs[i], envir) (from miniTidyR-package.R#1) : object 'bro' not found". I'm not sure why this occurred... perhaps it was an issue on my side.
• I couldn't call your vignette using browseVignettes(). Perhaps this thread may be of some help?

[ellognea]

Thank you for your feedback Rainer.

• I am also not sure where the 'bro' error comes from. A far as I can tell, we do not have anything called 'bro' in our package and got 0 error before submitting.

• Thanks for sharing the vignette thread. We opted for the below solution :
  
  and added it to our Readme as well
  

Did you get an error after calling devtools::install(build_vignettes=TRUE) before browseVignettes("miniTidyR") ?

Thanks again for your prompt feedback.

[rainerlempert]

@ellognea yes that works! Sorry I missed that!

[ellognea]

Thank you @rainerlempert .

• Solved: All of your tests passed, but there were 38 warning messages. I would recommend looking into this, and trying to reduce the number of warnings