fix: Portfolio Architecture V2 production audit - #19
Merged
Conversation
The Algorithmic 3D Lab section moved to labs.html in V2, but the Command Palette entry still used type:"scroll" against a same-page id. executeCommand resolves scroll targets with getElementById()?., so the command silently no-opped on every page except labs.html. Point it at the registry URL labs.html#algorithmic-3d-lab instead. project-detail.html also defaulted a missing ?project= parameter to a hardcoded "drivenfinity" slug, so the bare URL rendered an arbitrary archive project instead of the existing not-found state. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…stry Switching the SINAMA scenario replaced root.innerHTML, destroying the focused toggle and dropping keyboard focus to <body>. Recruiter Mode V2 already restores focus after re-render; mirror that behaviour here. The explorer also hardcoded scenario labels that portfolio-data.js already owns (sinamaEvidence.*.label), and shipped identical EN/TR ternaries so TR users saw English section labels. Read labels from the registry, translate the descriptive ones, and make conversation speaker names bilingual in the registry. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Adds regression coverage for the failure classes found in this audit: duplicate runtime loads, broken portfolio-data -> script -> portfolio-v2 boot order, direct legacy-script.js declarations, unpaired data-pv2 copy, the hardcoded project-detail slug, same-page scroll commands to relocated sections, a missing Labs anchor target, and Evidence Explorer truth drifting out of the registry. Each guard was verified to fail when its regression is reintroduced. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Running the documented npm run qa:lighthouse writes .lighthouseci/ reports into the repo root. Keep that generated output untracked. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
UAJOP
marked this pull request as ready for review
August 22, 2026 11:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-merge audit of Portfolio Architecture V2 (
0eec7c8). Audited the bootloader, both boot paths, Recruiter Mode V2, Ajoop, the Evidence Explorer, i18n, the dynamic archive route, request flow, responsive behaviour and performance — then fixed the defects found and added regression guards.Headline result
The V2 architecture itself is healthy. Across 18 pages there were 0 JS errors, 0 duplicate runtime loads, 0 broken assets and correct boot order on both the migrated path and the legacy
script.js-only path. The bugs found were narrower than the architecture.Fixes
labs.html, but the palette entry stayedtype:"scroll"against a same-page id;executeCommandresolves it withgetElementById()?.so it no-ops. Now navigates to the registry URL.<body>root.innerHTML, destroying the focused toggle. Recruiter V2 already restored focus; the explorer didn't. Mirrored that behaviour.portfolio-data.jsowningsinamaEvidence.*.label, and shipped identical EN/TR ternaries. Labels now come from the registry; descriptive strings and speaker names are bilingual./project-detail.htmlrendered an arbitrary projectparams.get("project") || "drivenfinity"bypassed the existing not-found state.Performance: no V2 regression
Local Lighthouse showed ~62-70 vs the ~94 baseline, so I isolated it:
Render-blocking is 4 CSS files, zero JS; the whole boot chain is ~59 ms. The gap is pre-existing Google Fonts + unpkg Boxicons latency, not V2. Left unchanged — see the follow-ups in the report.
Regression guards
qa-portfolio-consistency.jsgains coverage for duplicate runtime loads,portfolio-data → script → portfolio-v2boot order, directlegacy-script.jsdeclarations, unpaireddata-pv2copy, the hardcoded slug, same-page scroll commands to relocated sections, a missing Labs anchor, and Evidence Explorer drift. Each was verified to fail when its regression is reintroduced, then restored.Verification
qa:portfoliopass ·qa:html0 errors (67 pre-existing warnings) ·qa:spelling0 ·pa11y-ci11/11 · JS syntax 14/14 · links 0 broken (439 refs, 17 role deep links, 10 project slugs all resolve) · 72 viewport×page overflow checks clean at 1440/1366/768/390/360/844×390.No merge. Draft for review.
🤖 Generated with Claude Code