Skip to content

Preserve keyboard focus when answering native questions - #489

Open
BunsDev wants to merge 4 commits into
mainfrom
cf3-question-focus
Open

BunsDev wants to merge 4 commits into
mainfrom
cf3-question-focus

Conversation

@BunsDev

@BunsDev BunsDev commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Native-question submission dropped keyboard focus when validation disabled the input or an accepted answer removed it. Preserve the submitting control after a validation error and move focus to the answer/status after acceptance, while respecting focus deliberately moved elsewhere. Keep the existing turn-fold focus handoff.

The Electron regression reproduces both original failures and covers accepted, invalid and moved-focus paths while retaining exact composer draft, attachment-byte and reload-recovery assertions. This follows #487; #276 remains open for its remaining acceptance criteria.

Validation on signed source candidate 24735bba7a24bca025dd75005bbc29e2a0e76fc3: build and workspace/strict E2E typechecks passed; unit suites passed 2,300 tests with 26 skips; 13 focused Electron cases passed. Full E2E passed 482 desktop tests with seven skips and seven site tests, without a retry. Independent review found no actionable findings. The follow-up commit changes only the validation receipt and status text.

Evidence and preserved first failures are recorded in docs/reviews/2026-11-02-cf3-question-focus.md. Human, VoiceOver, live-provider and physical-phone acceptance remain separate. Other owners started GUI processes independently, so this receipt does not claim exclusive GUI access throughout the full run.

@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Nov 3, 2026 1:35am UTC

Request Review

Base automatically changed from cf3-question-regressions to main November 3, 2026 01:33
@github-code-quality

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

main b785054 cf3-question-focus 4f964fa +/-
66% 66% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

This branch was successfully deployed

1 active deployment
Preview — 4f964fa5 Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants