feat: declare acquireVsCodeApi on the global namespace - #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the bundled version of the
Messengerclass invscode-messenger-webview(the one built in thelibdirectory), the code that gets imported is something like this:vscode-api.js:
(makes sense it's empty, since
declareandinterfacedon't produce javascript code)messenger.js:
(this is wrong:
acquireVsCodeApiis defined onglobalThis/window, not in the module!)By moving the declaration of
acquireVsCodeApion the global namespace, the bundled code is now:(notice that there's no longer a reference to
vscode_api_1or./vscode-api)