Skip to content

[codex] reorganize platform folders - #2

Merged
Tygb99 merged 2 commits into
mainfrom
codex/reorganize-platform-folders
Jun 7, 2026
Merged

[codex] reorganize platform folders#2
Tygb99 merged 2 commits into
mainfrom
codex/reorganize-platform-folders

Conversation

@Tygb99

@Tygb99 Tygb99 commented Jun 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • Move the Android Gradle project into Android/ and shared assets/firmware into shared/.
  • Update CI, build docs, Windows scripts, and platform docs for the new folder layout.
  • Add a Korean iOS PhonePad README beside the existing English iOS README.

Validation

  • git diff --check origin/main...HEAD
  • git ls-files | rg -i '(local\.properties|\.apk$|\.aab$|\.jks$|\.keystore$|(^|/)\.env($|\.)|\.DS_Store|KakaoTalk|gpt의견|prd-phonepad|(^|/)build/|(^|/)\.gradle|(^|/)\.kotlin)' returned no tracked matches
  • From Android/: ./gradlew testDebugUnitTest assembleDebug lintDebug --stacktrace

Merge Notes

  • Android commands now need to run from Android/; the root-level Gradle wrapper moved to Android/gradlew.
  • CI and Windows helper scripts were updated to use the nested Android project path, but any external scripts/docs outside this repo should be checked for root-level Gradle assumptions.
  • Shared assets and dongle firmware now live under shared/; iOS docs reference shared/firmware/bridge-dongle/BLETouchMouse/BLETouchMouse.ino.
  • Local ignored artifacts such as build/, gpt의견/, Android build outputs, PRD drafts, and KakaoTalk CSV exports are intentionally not part of this PR.

@Tygb99 Tygb99 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Verdict: Comment / approval possible

No blocking correctness or security issue found. The folder reorganization and CI path updates look mostly consistent. I found a couple of small documentation/script UX issues worth fixing before or after merge.

⚠️ Warnings

  • README.md / README.ko.md / docs/MOBILE_APP.md / docs/ko/MOBILE_APP.md — The build examples do cd Android, but the following install examples use Android/app/build/... from the repository root. If a user runs the install command in the same shell after cd Android, it resolves as Android/Android/app/... and fails.
    • Suggested fix: use a subshell for the build step:
      (cd Android && ./gradlew :app:assembleDebug)
      "$ANDROID_HOME/platform-tools/adb" install -r Android/app/build/outputs/apk/debug/app-debug.apk
      or explicitly cd .. before the install command.

💡 Suggestions

  • Android/scripts/build-windows.ps1:84, Android/scripts/build-windows.ps1:89 — Error messages still point to the old setup path:
    Run .\scripts\setup-windows-dev.ps1 first.
    Since the script moved under Android/, this should say:
    Run .\Android\scripts\setup-windows-dev.ps1 first.

✅ Looks Good

  • app/Android/app/ and Gradle wrapper/settings migration are clean renames.
  • GitHub Actions now builds from Android/ and uploads Android/build/artifacts/....
  • shared/assets and shared/firmware paths are reflected in iOS/shared docs.
  • git diff --check main...HEAD passed during review.
  • GitHub check-runs for the PR head commit were successful.
  • No tracked local planning/build artifacts matched the repo hygiene patterns checked during review.

Validation note

I could not run the local Gradle command in the review container because Java/JDK is not installed there (JAVA_HOME is not set and no java command could be found). I relied on diff review plus the successful GitHub check-runs for build validation.


Reviewed by Hermes Agent.

@Tygb99 Tygb99 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review Summary

Verdict: LGTM / no blocking issues found

I re-reviewed the updated PR at fefc26a. The previous review notes were addressed:

  • Build examples now use (cd Android && ./gradlew :app:assembleDebug), so the following install commands still resolve from the repository root.
  • Android/scripts/build-windows.ps1 now points users to \.\Android\scripts\setup-windows-dev.ps1 in the missing Java/SDK error messages.

Validation checked

  • git diff --check origin/main...HEAD passed.
  • Tracked-file hygiene pattern check found no matching local/build/secret-style artifacts.
  • GitHub PR checks are passing:
    • Build debug APK — pass
    • Build debug APK — pass
  • Searched for stale path references around scripts/, firmware/bridge-dongle, assets/brand, Gradle build/install paths, and Android/Android; no problematic stale references found.

Note

I still could not run local Gradle in this container because Java/JDK is not installed here, but the GitHub Actions build/lint checks for the PR head are green.


Reviewed by Hermes Agent.

@Tygb99
Tygb99 marked this pull request as ready for review June 7, 2026 10:56
@Tygb99
Tygb99 merged commit 329355f into main Jun 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant