Moderation: Support appeal cooldowns#435
Draft
MathyFurret wants to merge 2 commits into
Draft
Conversation
Member
|
Looks good on a first scim, thanks! I'll try to take a closer look in the upcoming days if you don't mind. Or should I wait because draft? |
Felk
requested changes
Oct 13, 2024
Felk
left a comment
Felk
left a comment
Member
There was a problem hiding this comment.
Only some minor comments, mostly style. You may ignore individual comments if you disagree. Looks good, thanks!
Comment on lines
+79
to
+82
| /// <summary> | ||
| /// When a user can appeal. If null, the user is never allowed to appeal. | ||
| /// </summary> | ||
| public Instant? AppealDate { get; init; } |
Member
There was a problem hiding this comment.
Can you add a clarification how this value should get interpreted in the case the user isn't banned? Maybe it can just be any value, but that arbitrary value should bear no meaning in that case?
Comment on lines
+81
to
+82
| await _userRepo.SetAppealCooldown(targetUser, expiration); | ||
| await _appealCooldownLogRepo.LogAppealCooldownChange(targetUser.Id, "auto_appeal_cooldown", issuerUser.Id, now, DEFAULT_APPEAL_TIME); |
Member
There was a problem hiding this comment.
to make it impossible to change the appeal cooldown without logging, would it be better to put both into one call somehow? Not sure how example though
Comment on lines
+76
to
+83
| // First ban can be appealed after 1 month by default. | ||
| // I don't want to automatically calculate how many bans the user has had, because some might be joke/mistakes | ||
| // A mod should manually set the next appeal cooldown based on the rules. | ||
| var DEFAULT_APPEAL_TIME = Duration.FromDays(30); | ||
| Instant expiration = now + DEFAULT_APPEAL_TIME; | ||
| await _userRepo.SetAppealCooldown(targetUser, expiration); | ||
| await _appealCooldownLogRepo.LogAppealCooldownChange(targetUser.Id, "auto_appeal_cooldown", issuerUser.Id, now, DEFAULT_APPEAL_TIME); | ||
|
|
Member
There was a problem hiding this comment.
should this entire section only run if isBan?
Comment on lines
+208
to
+210
| string? issuerName = recentLog?.IssuerUserId == null | ||
| ? "<automated>" | ||
| : (await _userRepo.FindById(recentLog.IssuerUserId))?.Name; |
Member
There was a problem hiding this comment.
Might be impossible since we never delete anyone from the users repo as far as I know, but as a safeguard against failing to look up a user, maybe sth. like this?
Suggested change
| string? issuerName = recentLog?.IssuerUserId == null | |
| ? "<automated>" | |
| : (await _userRepo.FindById(recentLog.IssuerUserId))?.Name; | |
| string issuerName = recentLog?.IssuerUserId == null | |
| ? "<automated>" | |
| : (await _userRepo.FindById(recentLog.IssuerUserId))?.Name | |
| ?? $"<unknown user id ${recentLog.IssuerUserId}>"; |
Comment on lines
+217
to
+223
| return new CommandResult { Response = | ||
| targetUser.AppealDate is null | ||
| ? $"{targetUser.Name} is not eligible to appeal. {infoText}" | ||
| : targetUser.AppealDate < _clock.GetCurrentInstant() | ||
| ? $"{targetUser.Name} is eligible to appeal now. {infoText}" | ||
| : $"{targetUser.Name} will be eligible to appeal on {targetUser.AppealDate}. {infoText}" | ||
| }; |
Member
There was a problem hiding this comment.
not sure if dotnet format would like it, but making the ternary nesting a bit more visible with indentation might help a bit:
Suggested change
| return new CommandResult { Response = | |
| targetUser.AppealDate is null | |
| ? $"{targetUser.Name} is not eligible to appeal. {infoText}" | |
| : targetUser.AppealDate < _clock.GetCurrentInstant() | |
| ? $"{targetUser.Name} is eligible to appeal now. {infoText}" | |
| : $"{targetUser.Name} will be eligible to appeal on {targetUser.AppealDate}. {infoText}" | |
| }; | |
| return new CommandResult { Response = | |
| targetUser.AppealDate is null | |
| ? $"{targetUser.Name} is not eligible to appeal. {infoText}" | |
| : targetUser.AppealDate < _clock.GetCurrentInstant() | |
| ? $"{targetUser.Name} is eligible to appeal now. {infoText}" | |
| : $"{targetUser.Name} will be eligible to appeal on {targetUser.AppealDate}. {infoText}" | |
| }; |
Or, given the infoText gets appended anyway, maybe:
Suggested change
| return new CommandResult { Response = | |
| targetUser.AppealDate is null | |
| ? $"{targetUser.Name} is not eligible to appeal. {infoText}" | |
| : targetUser.AppealDate < _clock.GetCurrentInstant() | |
| ? $"{targetUser.Name} is eligible to appeal now. {infoText}" | |
| : $"{targetUser.Name} will be eligible to appeal on {targetUser.AppealDate}. {infoText}" | |
| }; | |
| return new CommandResult { Response = ( | |
| targetUser.AppealDate is null | |
| ? $"{targetUser.Name} is not eligible to appeal." | |
| : targetUser.AppealDate < _clock.GetCurrentInstant() | |
| ? $"{targetUser.Name} is eligible to appeal now." | |
| : $"{targetUser.Name} will be eligible to appeal on {targetUser.AppealDate}." | |
| ) + " " + infoText | |
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening for preliminary reviews as I work on the web side of this