Fix stale check_model doctest broken by the #1438 fence fix#1439
Merged
Conversation
…a generic error, not the old specific message
Contributor
|
DynamicPPL.jl documentation for PR #1439 is available at: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main's Doctests workflow is currently red: https://github.com/TuringLang/DynamicPPL.jl/actions/runs/29509495151/job/87658917625
#1438 fixed a real markdown bug (an unclosed ``` fence in
check_model's docstring), which is good, but closing that fence changed where Documenter thinks thejldoctestblock ends. That exposed a doctest that was already stale: the "Incorrect model" example expectedbut
check_model's actual behavior for repeatedVarNames (since at least theDebugAccumulatorrework) is to@warnper repeated variable and then raise the genericerror_on_failuremessage atsrc/debug_utils.jl:265-266:Updated the docstring to match, mirroring the same warning-block style already used in the "Correct model" example just above it. Verified locally:
GROUP=Doctests julia --project=. -e 'using Pkg; Pkg.test()'passes (1/1) on Julia 1.12, matching the CI job that was failing.