perf: optimize login query to reduce database hits#83
Conversation
Combine username and email checking into a single query during login/registration to improve response performance. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
1 participant
What:
Optimized
get_user_by_username_or_emailindb/crud.pyto use a single SQLAlchemy query with theor_operator instead of making two separate queries to the database.Why:
To eliminate unnecessary database hits when looking up users during login. Previously, if the email match failed, a second query was executed to check for the username.
Impact:
Reduces database round-trips by up to 50% for login operations, significantly lowering DB load during authentication.
Measurement:
Verified logic manually ensuring login functions correctly with both username and email formats while profiling single DB transaction behavior.
PR created automatically by Jules for task 17229910636549956988 started by @Tugamer89