fix(security): [security improvement]#178
Conversation
- Added MAX_STATES constant (10000) to AbstractAutomatonBuilder. - Added check in addState to throw IllegalStateException if limit exceeded. - Prevents memory exhaustion attacks via excessive state creation. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
1 participant
Severity: MEDIUM
Vulnerability: Unbounded state creation in automaton builder
Impact: A malicious user could potentially cause a Denial of Service (DoS) via memory exhaustion by continually adding states.
Fix: Introduced a MAX_STATES limit (10000) in AbstractAutomatonBuilder that throws an exception if exceeded.
Verification: Ran unit tests and spotless plugin to ensure no regressions.
PR created automatically by Jules for task 12832596417883300639 started by @Tugamer89