fix(security): [HIGH] resolve uncontrolled memory consumption DoS in automaton builder#174
fix(security): [HIGH] resolve uncontrolled memory consumption DoS in automaton builder#174Tugamer89 wants to merge 1 commit into
Conversation
- Added a `MAX_STATES` limit to `AbstractAutomatonBuilder.java` to prevent infinite state creation loops from exhausting memory during manual automaton construction. - Created `AbstractAutomatonBuilderSecurityTest.java` to verify the DoS prevention logic. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
1 participant
Severity: HIGH
Vulnerability: Unbounded state creation in
AbstractAutomatonBuilderallows manual automaton construction loops to consume arbitrary amounts of memory, potentially leading to a Denial-of-Service (DoS) condition viaOutOfMemoryErrororIllegalStateExceptionon JVM memory exhaustion.Impact: An attacker supplying malicious input to code paths that dynamically construct automata via the public builder API could crash the application by intentionally triggering an infinite state creation loop.
Fix: Implemented a hard limit (
MAX_STATES = 10000) withinAbstractAutomatonBuilder#addState. If this limit is exceeded when attempting to add a new state, anIllegalStateExceptionis thrown, securely terminating the operation before memory is exhausted.Verification: Added
AbstractAutomatonBuilderSecurityTestwhich iteratively adds 10,000 states and verifies that attempting to add the 10,001st state correctly throws anIllegalStateException. Tested manually withmvn test.PR created automatically by Jules for task 14210009594660108661 started by @Tugamer89