Skip to content

Vscript godspots only active when all players stand on it - #505

Open
Nesciuse wants to merge 7 commits into
Tsuey:masterfrom
Nesciuse:vscript-godspots
Open

Vscript godspots only active when all players stand on it#505
Nesciuse wants to merge 7 commits into
Tsuey:masterfrom
Nesciuse:vscript-godspots

Conversation

@Nesciuse

@Nesciuse Nesciuse commented Apr 6, 2024

Copy link
Copy Markdown
Collaborator

Changes behaviour of changes in this commit to only activate godspot when all survivors are standing on it. Done via added make_trig_godspot function that spawns script_trigger_multiple based on the size of nav area that's meant to be a godspot. Uses OnEntireTeamStartTouch\OnEntireTeamEndTouch outputs

@Tsuey
Tsuey requested a review from Treescrub April 7, 2024 13:40
@alexiscoutinho

alexiscoutinho commented Apr 8, 2024

Copy link
Copy Markdown
Contributor

That still wouldn't completely solve the griefing problem though. If only one player survives in a finale, he could still cheese it by going to the God spot.

@Shadowysn

Copy link
Copy Markdown

That still wouldn't completely solve the griefing problem though. If only one player survives in a finale, he could still cheese it by going to the God spot.

True, but at this point everyone else's attention would be focused entirely on that survivor and can make a decision to votekick more easily, as opposed to in the heat of gameplay.

@Treescrub Treescrub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, seems to be fairly robust.

I did come across a bug where standing in the godspot while a incapacitated teammate is nearby but outside the trigger, reviving the teammate, then leaving the godspot will leave it active until everyone is inside the trigger. It doesn't particularly strike me as a concern, but worth pointing out.

Also the trigger isn't shown with ShowUpdate(). Should probably either use trigger_multiple or change ShowUpdate to include script_trigger_multiple for it to properly display.

Comment thread root/scripts/vscripts/community/functions.nut Outdated
Comment thread root/scripts/vscripts/community/functions.nut Outdated
Comment thread root/scripts/vscripts/community/functions.nut Outdated
-targetname
@Nesciuse
Nesciuse requested a review from Treescrub April 10, 2024 00:12
@alexiscoutinho

Copy link
Copy Markdown
Contributor

Is allowincap = 0 really necessary for speedrunners?

@Nesciuse

Nesciuse commented Apr 10, 2024

Copy link
Copy Markdown
Collaborator Author

Probably unnecesseray considering godspot is less effective with incapee alive and speedrunner would ensure bots aren't alive. Also would probably prevent the rare issue daroot pointed out if set to 1

@Tsuey

Tsuey commented Apr 15, 2024

Copy link
Copy Markdown
Owner

Before we merge, you'll want to add the #508 functions.nut scripthelp lines into this PR to fix the merge conflicts, and add another scripthelp for this new make_trig_godspot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants