Fixes additions - #308
Open
skesssler wants to merge 5 commits into
Open
Conversation
Fixed lighting issues by recalculating the normals, and added sharps in some edges that needed them
Fixed inaccurate collision on most sides of the collision mesh
Fixed a very inaccurate collision model that was too thick and would prevent bullet penetration to work properly. Hit registration was also inacurate, causing projectiles to hit invisible bumps.
In the dlc3 pak, there were 4 textures added in models/props_exteriors/psds, that are twice the resolution of their original counterparts. These versions are unused, because the vmt's still pointed to the original dowscaled ones. This updates the vmt's to point to the higher resolution versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting, I acknowledge the topic has been discussed (issues or elsewhere), that I know what is required of compiled assets (CONTRIBUTING.md -> Coordination), and if these are text or script files I'll submit un-modifiied live game files first.
What exactly is changed and why?
-Fixed inaccurate collision on the closed CEDA trailer model. The only time it's used on vanilla campaigns the problematic parts are out of bounds for survivors, but on custom campaigns, survivors can walk up to and bump on the protruding inaccurate areas.
-Fixed inaccurate lighting on console model. Model is not used many times in vanilla game, but it's used in Blood Harvest's finale as the escape radio. When using a flashlight, the model's lighting will appear inverted. So light would shine from the back, and shadows would show up on the front. This recalculates the normals fixing the issue
Is there anything specific that needs review? (Consider marking as a draft.)
Just the two models, (models/props_c17/consolebox01) and (models/props_vehicles/ceda_trailer_exterior)
Does this address any open issues?
No