Added navigation icon styling to shared theme assets - #593
Merged
Conversation
Support icons rendered by Ghost's navigation helper across all official monorepo themes via @tryghost/shared-theme-assets v2.7.2. Companion to TryGhost/Source#205 and TryGhost/Casper#1116. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. Only developers with an assigned seat can start an on-demand review using credits. Ask an admin to assign your seat or change the review continuation mode in Billing. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (19)
📒 Files selected for processing (35)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
9larsons
approved these changes
Aug 24, 2026
minimaluminium
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.nav aand.nav-iconstyles to@tryghost/shared-theme-assets(v1 header + v2 navbar) so navigation icons render correctly alongside labelsCompanion to:
Test plan
pnpm build— all themes rebuilt with nav-icon CSS inassets/built/screen.csspnpm test:ci --theme taste|wave|dope|headline— no fatal gscan issuesnavigationIconslab in Ghost Admin → Settings → LabsMade with Cursor