Skip to content

Added navigation icon styling to shared theme assets - #593

Merged
louisghost merged 1 commit into
mainfrom
navigation-icons
Aug 25, 2026
Merged

Added navigation icon styling to shared theme assets#593
louisghost merged 1 commit into
mainfrom
navigation-icons

Conversation

@louisghost

@louisghost louisghost commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Added .nav a and .nav-icon styles to @tryghost/shared-theme-assets (v1 header + v2 navbar) so navigation icons render correctly alongside labels
  • Bumped shared assets to 2.7.2 and rebuilt all 16 official monorepo themes

Companion to:

Test plan

  • pnpm build — all themes rebuilt with nav-icon CSS in assets/built/screen.css
  • pnpm test:ci --theme taste|wave|dope|headline — no fatal gscan issues
  • Enable navigationIcons lab in Ghost Admin → Settings → Labs
  • Add a navigation item with an icon (primary + secondary)
  • Verify icon + label alignment in header and footer nav
  • Spot-check Dope off-canvas menu and Headline footer nav

Made with Cursor

Support icons rendered by Ghost's navigation helper across all official
monorepo themes via @tryghost/shared-theme-assets v2.7.2.

Companion to TryGhost/Source#205 and TryGhost/Casper#1116.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 50 minutes.

View limit details

Limit details: You’ve used the included review currently available.

Only developers with an assigned seat can start an on-demand review using credits. Ask an admin to assign your seat or change the review continuation mode in Billing.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 83bd590e-8c6a-4472-8214-b3680dde3d4f

📥 Commits

Reviewing files that changed from the base of the PR and between 48c70ae and 8271580.

⛔ Files ignored due to path filters (19)
  • packages/alto/assets/built/screen.css.map is excluded by !**/*.map
  • packages/bulletin/assets/built/screen.css.map is excluded by !**/*.map
  • packages/dawn/assets/built/screen.css.map is excluded by !**/*.map
  • packages/digest/assets/built/screen.css.map is excluded by !**/*.map
  • packages/dope/assets/built/main.min.js is excluded by !**/*.min.js
  • packages/dope/assets/built/screen.css.map is excluded by !**/*.map
  • packages/ease/assets/built/main.min.js is excluded by !**/*.min.js
  • packages/ease/assets/built/screen.css.map is excluded by !**/*.map
  • packages/edge/assets/built/screen.css.map is excluded by !**/*.map
  • packages/edition/assets/built/screen.css.map is excluded by !**/*.map
  • packages/episode/assets/built/screen.css.map is excluded by !**/*.map
  • packages/headline/assets/built/screen.css.map is excluded by !**/*.map
  • packages/journal/assets/built/screen.css.map is excluded by !**/*.map
  • packages/london/assets/built/screen.css.map is excluded by !**/*.map
  • packages/ruby/assets/built/screen.css.map is excluded by !**/*.map
  • packages/solo/assets/built/screen.css.map is excluded by !**/*.map
  • packages/taste/assets/built/screen.css.map is excluded by !**/*.map
  • packages/wave/assets/built/screen.css.map is excluded by !**/*.map
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (35)
  • packages/_shared/assets/css/v1/components/header.css
  • packages/_shared/assets/css/v2/components/navbar.css
  • packages/_shared/package.json
  • packages/alto/assets/built/screen.css
  • packages/alto/package.json
  • packages/bulletin/assets/built/screen.css
  • packages/bulletin/package.json
  • packages/dawn/assets/built/screen.css
  • packages/dawn/package.json
  • packages/digest/assets/built/screen.css
  • packages/digest/package.json
  • packages/dope/assets/built/screen.css
  • packages/dope/package.json
  • packages/ease/assets/built/screen.css
  • packages/ease/package.json
  • packages/edge/assets/built/screen.css
  • packages/edge/package.json
  • packages/edition/assets/built/screen.css
  • packages/edition/package.json
  • packages/episode/assets/built/screen.css
  • packages/episode/package.json
  • packages/headline/assets/built/screen.css
  • packages/headline/package.json
  • packages/journal/assets/built/screen.css
  • packages/journal/package.json
  • packages/london/assets/built/screen.css
  • packages/london/package.json
  • packages/ruby/assets/built/screen.css
  • packages/ruby/package.json
  • packages/solo/assets/built/screen.css
  • packages/solo/package.json
  • packages/taste/assets/built/screen.css
  • packages/taste/package.json
  • packages/wave/assets/built/screen.css
  • packages/wave/package.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch navigation-icons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@louisghost
louisghost merged commit cf717a8 into main Aug 25, 2026
71 checks passed
@louisghost
louisghost deleted the navigation-icons branch August 25, 2026 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants