Skip to content

import fix for some helpers and steps#12

Open
EliChin wants to merge 1 commit into
TrueCloudLab:masterfrom
EliChin:fix/import
Open

import fix for some helpers and steps#12
EliChin wants to merge 1 commit into
TrueCloudLab:masterfrom
EliChin:fix/import

Conversation

@EliChin

@EliChin EliChin commented Mar 1, 2023

Copy link
Copy Markdown

Some imports were not full and resulted in run failures (at least, in VSCode).

Comment thread pytest_tests/steps/s3_gate_base.py Outdated
from frostfs_testlib.shell import Shell
from pytest import FixtureRequest

import pytest_tests.steps.s3_gate_bucket

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest maintaining a single style: from ... import ....

from pytest_tests.steps import s3_gate_bucket

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Signed-off-by: Liza <e.chichindaeva@yadro.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants