Conversation
Mark quarantining outline + implementation done, update label-format option to --label-format v1|v2|v2-full, and note declassification consolidation status (PR #151). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
A value downgrade computed the result's integrity level as the tainted target level, which incorrectly *raised* it. Per the agreed fix in #159, the integrity of a downgraded value is now glb(data.tlev, taintedLevTo), so e.g. `pdowngrade(x raisedTo {alice,bob}, authority, {alice})` yields `%{}` instead of `%{alice}`. - downgrading.mts: pass glb(data.tlev, taintedLevTo) as the LCopyVal tlev. - Lval.mts: expose LCopyVal's third (integrity) arg; make posInfo and the nullable constructor params explicitly `| null` for stricter typing. - tests/lib/IfcUtil.golden: regenerate declassifyDeep/downgradeDeep section to reflect the corrected integrity (%{}). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add a "Commit quality" policy to CLAUDE.md: AI-generated commits must be verified before committing; changes that cannot be verified (e.g. their exercising tool hangs/is unavailable) must be held in the working tree and surfaced, not committed on faith; verified changes must not be bundled with unverified ones. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Rollup's tree-shaking pass hangs indefinitely (observed 5+ CPU-hours) on the compiled runtime's circular module graph (runtimeMonitored <-> MailboxProcessor <-> QuarantineUtils <-> deserialize, and <-> UserRuntime <-> exit). The hang is entirely in tree-shaking: isolation showed plain `rollup` with zero plugins hangs, while the full pipeline (resolve+commonjs+json+terser) with `treeshake: false` produces a valid 148 KB minified bundle in ~1s. Dead-code elimination is unnecessary here since terser still minifies, so disable tree-shaking. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Apply `npm audit fix` across the runtime and notebook trees. Notably bumps @rollup/plugin-terser 0.4 -> 1.0 (fixes a high-severity serialize-javascript RCE advisory) and dedupes libp2p transitive deps (multiformats, uint8arrays, protons-runtime). Verified: full `make test` green (890/890, multinode included) on the updated tree; the rollup bundle builds and minifies correctly under plugin-terser 1.0 (148 KB, valid JS). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- .gitignore: ignore the /build/ distribution bundle produced by `make dist` / `rollup -c` (was previously untracked-but-unignored). - rt/Makefile: `clean` now also removes tsconfig.tsbuildinfo. Removing only built/ left tsc's incremental cache behind, so a subsequent build emitted nothing (or regenerated stale layouts). This is what left the obsolete rt/built/src/ duplicate tree around after the rootDir change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The hang is confirmed (5+ CPU-hours; ~1s with treeshake off) but its exact trigger is not. Reword the comment to present the circular dependencies as present-but-unconfirmed rather than the established cause, and reference the known Rollup tree-shaking pathology class (rollup/rollup#5729). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Move all human-relevant reference material out of CLAUDE.md so it holds only agent-specific directives. README.md becomes a thin landing page; installation, development, architecture, contributing, and networking reference move into docs/. - CLAUDE.md: agent directives only; add "Writing documentation" rule against editorializing; link to the new docs. - README.md: intro, components, repository layout, quick start, docs index. - docs/INSTALL.md, DEVELOPMENT.md, ARCHITECTURE.md, CONTRIBUTING.md, NETWORKING.md: split reference material, each with a scope blurb. - NETWORKING.md: replace stale websocket-star node-discovery section with the mechanisms actually used (bootstrap, mDNS, kad-DHT; circuit relay v2 for NAT), verified against rt/src/p2p/p2p.mts. - De-editorialize inherited prose. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Bump typescript ^5.8.3 -> ^6.0.3 in root and notebook. Add explicit rootDir to notebook/tsconfig.json (TS6 now requires it for emit, TS5011). Config-only; no source changes. rt/p2p-tools/relay build clean, notebook builds clean, all 890 golden tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the
dev-ts6branch intodev. CI (build+tests and docker image) is green on the tip commit.TypeScript 6.0 migration
typescript^5.8.3→^6.0.3(root + notebook).rootDirtonotebook/tsconfig.json— TS6 now requires it for emit (error TS5011).rt,p2p-tools,relaytsconfigs (Node16 module/resolution, ES2022,types: ["node"], explicitrootDir).rt/p2p-tools/relay/notebookall build clean; all 890 golden tests pass.Build / infra
.gitignoredist build output;rt cleanwipes the tsc cache.npm audit fix— resolve dependency advisories.Docs
CLAUDE.mdintodocs/(INSTALL, DEVELOPMENT, ARCHITECTURE, CONTRIBUTING, NETWORKING);CLAUDE.mdnow holds agent directives only;README.mdis a thin landing page.rt/src/p2p/p2p.mts.Other
fix: downgrade no longer raises the integrity (type) level(Downgrading raises type level #159).Verification
make all+bin/golden: all 890 tests pass.dev-ts6: "Build project and run tests" ✅, "Build docker image and push to registry" ✅.