Skip to content

Update to Java 11 and Other Simple Cleanup - #12

Open
VestOfHolding wants to merge 2 commits into
Trifindo:masterfrom
VestOfHolding:Java11
Open

Update to Java 11 and Other Simple Cleanup#12
VestOfHolding wants to merge 2 commits into
Trifindo:masterfrom
VestOfHolding:Java11

Conversation

@VestOfHolding

Copy link
Copy Markdown
  • Update to Java 11
  • Other library/dependency updates.
  • Updating code to take advantage of newer Java features (Note: Zero functional changes.)
  • General code cleanup including, but not limited to:
    • Cleaning up redundant code such as unused imports and unthrown exceptions. Highly recommend using an IDE such as IntelliJ to help catch these things easily if you're not already.
    • Inverting a number of if statements to simply return instead of tabbing large amounts of code. Keeps things more readable and gives you more space to work with instead of being 5 tabs in on some of these methods. Though really your other main solution is going to be breaking out more of the code into smaller methods.
    • Updating variables everywhere I could find such as ArrayList to be declared more generically (List in this case). There's nothing specifically about the ArrayList implementation that seems to help you here, and it's good habit to be in in general.
    • Fixed not using generics properly. Don't forget to say what the type is (such as <String>) whenever you're using a generic class.

Other notes:

  • The Java 11 update is going to give you a performance boost for free. So would updating to Java 17, but I figured one big step at a time here.
  • Please add some unit tests. Zero tests on a project of this size is just heartbreaking, lol.
  • In general, I did not change any functionality. Only reformatted what was already there.
  • I noticed you have large swathes of unused and commented out code. Probably worth going through and culling that.

@VestOfHolding VestOfHolding changed the title Update to Java 11 Update to Java 11 and Other Simple Cleanup Dec 25, 2021
@VestOfHolding

Copy link
Copy Markdown
Author

Just came across this again, and I see it has no merge conflicts. Any chance of it getting merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant