Track MOD tempo via inbound transport WS message#168
Merged
sastraxi merged 7 commits intoJun 11, 2026
Conversation
mod-ui broadcasts 'transport {rolling} {bpb} {bpm} {sync}' on tempo change
and in the connect dump. Parse it and update TapTempo unconditionally, so the
device tracks MOD tempo whether or not tap-tempo mode is enabled.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
rreichenbach
left a comment
rreichenbach
left a comment
Collaborator
There was a problem hiding this comment.
This one isn't working how I would expect. But perhaps, just checking out the PR isn't including other prerequisite changes?
If I tap in a new tempo, I don't see it reflected in the MOD-UI unless I do a browser refresh. This used to work.
And I thought based on the description that MOD-UI tempo changes would be reflected back to the LCD, but I'm not seeing that either.
Collaborator
Author
|
@rreichenbach got it -- this was more of an opportunistic sync fix, but it sounds like MIDI tap tempo is actually broken right now. #167 may have fixed it; I'll look into it. |
# Conflicts: # modalapi/mod.py # modalapi/modhandler.py # modalapi/ws_protocol.py # tests/v3/test_plugins.py
Collaborator
Author
|
Fix landed, ready for re-review. |
rreichenbach
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mod-ui broadcasts
transport {rolling} {bpb} {bpm} {sync}on tempo change and in the connect dump. This branch parses it and updates TapTempo unconditionally, so the device tracks MOD tempo whether or not tap-tempo mode is enabled.Note that there is no live LCD refresh here; the footswitch BPM label refreshes on its normal redraw cycle (if it's visible at all).