Conversation
|
Looks like we need to bump |
MarijnS95
changed the title
glam upper bound to <= 0.25glam upper bound to <= 0.30\
MarijnS95
changed the title
glam upper bound to <= 0.30\glam upper bound to <= 0.30
| fn local_coord_to_offset(&self, xyz: LocalCoord) -> Index { | ||
| Index( | ||
| (((xyz.0[0] & (Self::DIM - 1)) >> Self::TOTAL) << (2 * Self::LOG_2_DIM)) | ||
| + (((xyz.0[1] & (Self::DIM - 1)) >> Self::TOTAL) << Self::LOG_2_DIM) | ||
| + ((xyz.0[2] & (Self::DIM - 1)) >> Self::TOTAL), | ||
| ) |
There was a problem hiding this comment.
@jasperdewinther can you double-check this? It seems surprising that going from local coordinates shifts right by Self::TOTAL, but going from offset to local coordinates below does not. That is only performed in offset_to_global_coord(). Perhaps it is in the wrong place?
There was a problem hiding this comment.
Why does this code even change?
| [dev-dependencies] | ||
| bevy = { version = "0.11", default-features = false, features = ["bevy_pbr"] } | ||
| bevy-aabb-instancing = "0.10" | ||
| bevy_egui = "0.22" | ||
| smooth-bevy-cameras = "0.9" |
There was a problem hiding this comment.
I have tried but failed (thus far) to push the dependency updates through to these crates. Will try again but we might just delete the samples as it's preventing us from bumping an entire dependency stack.
There was a problem hiding this comment.
Trying in fslabs/bevy_aabb_instancing#27 again but Bevy internals are incredibly complex, especially when never using it and jumping straight into deep custom rendering implementations and upgrading it from 0.11 to 0.17 with many new/changed abstractions.
A downstream consumer is moving its workspace to 0.33 to line up with a `[patch]` onto a fork carrying portable archived `rkyv` types. Any version this crate does not accept forces a second `glam` into that graph. No code change: 0.33 gates the numeric types behind features, but `default` still enables `all-types`, and this crate takes `glam` with default features, so `DVec3` and friends stay available. Verified to build at both ends of the range, 0.30.10 and 0.33.3. There are no tests in this crate, so compiling is the only evidence available.
MarijnS95
changed the title
glam upper bound to <= 0.30glam upper bound to <= 0.33
MarijnS95
changed the title
glam upper bound to <= 0.33glam upper bound to <= 0.33 and delete bevy examples (😢)
MarijnS95
changed the title
glam upper bound to <= 0.33 and delete bevy examples (😢)glam version range to >=0.18, <=0.33
2 participants
Supersedes #61.
Widens the accepted
glamrange so a downstream consumer can move its workspace to 0.33 without dragging a secondglaminto the graph - any version this crate does not accept forces one, since a[patch]removes the crates.io copy as a resolution candidate for everyone else.No code change is needed: 0.33 gates the numeric types behind features, but
defaultstill enablesall-typesand this crate takesglamwith default features, soDVec3and friends stay available. Verified to build at both ends of the range, 0.30.10 and 0.33.3; there are no tests here, so compiling is the only evidence available.Also drops the
bevy-based dev-dependencies, which no longer build.