Centralizing OTEL configuration and applying it to more deployment options - #111
Merged
Conversation
hyi
approved these changes
May 18, 2026
hyi
left a comment
hyi
left a comment
Contributor
There was a problem hiding this comment.
@EvanDietzMorris Looks good. Agreed creating otel.py under services and calling it from post_fork() hook in gunicorn.conf.py is a better design and increases code readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first implementation of setting up OTEL as a post hook was only applied to the plater-clustered-docker deployment, and all the OTEL code lived in that docker/deployment specific directory.
This PR moves the OTEL set up to a more findable centralized location and also applies it to the non-clustered deployment as well as the main entry of server.py.
Note that this still doesn't allow us to use OTEL when deploying with a uvicorn --reload