Remove file profile seeding from startup

FileProcessor.BusinessLogic.Tests/DummyFileProcessorDomainService.cs

@@ -27,10 +27,6 @@ public async Task<Result> ProcessTransactionForFileLine(FileCommands.ProcessTran
 }
 
 public class DummyFileProcessorManager : IFileProcessorManager {
-    public async Task<Result> EnsureSeededFileProfiles(CancellationToken cancellationToken) {
-        return Result.Success();
-    }
-
     public async Task<Result<List<FileProfileModel>>> GetAllFileProfiles(CancellationToken cancellationToken) {
         return Result.Success();
     }

FileProcessor.BusinessLogic/Managers/FileProcessorManager.cs

@@ -76,11 +76,6 @@ public async Task<Result<FileProfileModel>> GetFileProfile(Guid fileProfileId,
             return await this.FileProfileManager.GetFileProfile(fileProfileId, cancellationToken);
         }
 
-        public async Task<Result> EnsureSeededFileProfiles(CancellationToken cancellationToken)
-        {
-            return await this.FileProfileManager.EnsureSeededFileProfiles(cancellationToken);
-        }
-
         private async Task<EstateManagementContext> GetContext(Guid estateId)
         {
             ResolvedDbContext<EstateManagementContext>? resolvedContext = this.Resolver.Resolve(EstateManagementDatabaseName, estateId.ToString());

FileProcessor.BusinessLogic/Managers/FileProfileManager.cs

@@ -17,31 +17,16 @@ namespace FileProcessor.BusinessLogic.Managers;
 
 public class FileProfileManager : IFileProfileManager
 {
-    private readonly List<FileProfileModel> SeedProfiles;
-
     private readonly IAggregateRepository<FileProfileAggregateRoot, DomainEvent> FileProfileAggregateRepository;
 
-    public FileProfileManager(List<FileProfileModel> seedProfiles,
-                              IAggregateRepository<FileProfileAggregateRoot, DomainEvent> fileProfileAggregateRepository)
+    public FileProfileManager(IAggregateRepository<FileProfileAggregateRoot, DomainEvent> fileProfileAggregateRepository)
     {
-        this.SeedProfiles = seedProfiles;
         this.FileProfileAggregateRepository = fileProfileAggregateRepository;
     }
 
-    public async Task<Result> EnsureSeededFileProfiles(CancellationToken cancellationToken)
-    {
-        Result<FileProfileAggregateRoot> aggregateResult = await this.LoadAggregate(cancellationToken, true);
-        if (aggregateResult.IsFailed)
-        {
-            return ResultHelpers.CreateFailure(aggregateResult);
-        }
-
-        return Result.Success();
-    }
-
     public async Task<Result<List<FileProfileModel>>> GetAllFileProfiles(CancellationToken cancellationToken)
     {
-        Result<FileProfileAggregateRoot> aggregateResult = await this.LoadAggregate(cancellationToken, false);
+        Result<FileProfileAggregateRoot> aggregateResult = await this.LoadAggregate(cancellationToken);
         if (aggregateResult.IsFailed)
         {
             return ResultHelpers.CreateFailure(aggregateResult);
@@ -52,7 +37,7 @@ public async Task<Result<List<FileProfileModel>>> GetAllFileProfiles(Cancellatio
 
     public async Task<Result<FileProfileModel>> GetFileProfile(Guid fileProfileId, CancellationToken cancellationToken)
     {
-        Result<FileProfileAggregateRoot> aggregateResult = await this.LoadAggregate(cancellationToken, false);
+        Result<FileProfileAggregateRoot> aggregateResult = await this.LoadAggregate(cancellationToken);
         if (aggregateResult.IsFailed)
         {
             return ResultHelpers.CreateFailure(aggregateResult);
@@ -69,7 +54,7 @@ public async Task<Result<FileProfileModel>> GetFileProfile(Guid fileProfileId, C
 
     public async Task<Result<FileProfileModel>> CreateFileProfile(CreateFileProfileRequest request, CancellationToken cancellationToken)
     {
-        Result<FileProfileAggregateRoot> aggregateResult = await this.LoadAggregate(cancellationToken, true);
+        Result<FileProfileAggregateRoot> aggregateResult = await this.LoadAggregate(cancellationToken);
         if (aggregateResult.IsFailed)
         {
             return ResultHelpers.CreateFailure(aggregateResult);
@@ -93,7 +78,7 @@ public async Task<Result<FileProfileModel>> CreateFileProfile(CreateFileProfileR
 
     public async Task<Result<FileProfileModel>> UpdateFileProfile(Guid fileProfileId, UpdateFileProfileRequest request, CancellationToken cancellationToken)
     {
-        Result<FileProfileAggregateRoot> aggregateResult = await this.LoadAggregate(cancellationToken, true);
+        Result<FileProfileAggregateRoot> aggregateResult = await this.LoadAggregate(cancellationToken);
         if (aggregateResult.IsFailed)
         {
             return ResultHelpers.CreateFailure(aggregateResult);
@@ -117,7 +102,7 @@ public async Task<Result<FileProfileModel>> UpdateFileProfile(Guid fileProfileId
 
     public async Task<Result> ArchiveFileProfile(Guid fileProfileId, CancellationToken cancellationToken)
     {
-        Result<FileProfileAggregateRoot> aggregateResult = await this.LoadAggregate(cancellationToken, true);
+        Result<FileProfileAggregateRoot> aggregateResult = await this.LoadAggregate(cancellationToken);
         if (aggregateResult.IsFailed)
         {
             return ResultHelpers.CreateFailure(aggregateResult);
@@ -132,7 +117,7 @@ public async Task<Result> ArchiveFileProfile(Guid fileProfileId, CancellationTok
         return await this.FileProfileAggregateRepository.SaveChanges(aggregateResult.Data, cancellationToken);
     }
 
-    private async Task<Result<FileProfileAggregateRoot>> LoadAggregate(CancellationToken cancellationToken, bool seedIfMissing)
+    private async Task<Result<FileProfileAggregateRoot>> LoadAggregate(CancellationToken cancellationToken)
     {
         Result<FileProfileAggregateRoot> aggregateResult = await this.FileProfileAggregateRepository.GetLatestVersion(FileProfileAggregateRoot.FileProfileCollectionId, cancellationToken);
         if (aggregateResult.IsSuccess)
@@ -145,49 +130,6 @@ private async Task<Result<FileProfileAggregateRoot>> LoadAggregate(CancellationT
             return ResultHelpers.CreateFailure<FileProfileAggregateRoot>(aggregateResult);
         }
 
-        FileProfileAggregateRoot aggregate = FileProfileAggregateRoot.Create();
-        if (seedIfMissing && this.SeedProfiles.Any())
-        {
-            Result<FileProfileAggregateRoot> seeded = this.SeedAggregate(aggregate);
-            if (seeded.IsFailed)
-            {
-                return seeded;
-            }
-
-            Result saveResult = await this.FileProfileAggregateRepository.SaveChanges(seeded.Data, cancellationToken);
-            if (saveResult.IsFailed)
-            {
-                return ResultHelpers.CreateFailure<FileProfileAggregateRoot>(saveResult);
-            }
-
-            return Result.Success(seeded.Data);
-        }
-
-        return Result.Success(aggregate);
-    }
-
-    private Result<FileProfileAggregateRoot> SeedAggregate(FileProfileAggregateRoot aggregate)
-    {
-        foreach (FileProfileModel fileProfile in this.SeedProfiles)
-        {
-            CreateFileProfileRequest request = new CreateFileProfileRequest
-            {
-                FileProfileId = fileProfile.FileProfileId,
-                Name = fileProfile.Name,
-                ListeningDirectory = fileProfile.ListeningDirectory,
-                RequestType = fileProfile.RequestType,
-                OperatorName = fileProfile.OperatorName,
-                LineTerminator = fileProfile.LineTerminator,
-                FileFormatHandler = fileProfile.FileFormatHandler
-            };
-
-            Result createResult = aggregate.CreateProfile(request);
-            if (createResult.IsFailed)
-            {
-                return ResultHelpers.CreateFailure<FileProfileAggregateRoot>(createResult);
-            }
-        }
-
-        return Result.Success(aggregate);
+        return Result.Success(FileProfileAggregateRoot.Create());
     }
 }

FileProcessor.BusinessLogic/Managers/IFileProcessorManager.cs

@@ -20,8 +20,6 @@ public interface IFileProcessorManager
 
         Task<Result<FileProfileModel>> GetFileProfile(Guid fileProfileId, CancellationToken cancellationToken);
 
-        Task<Result> EnsureSeededFileProfiles(CancellationToken cancellationToken);
-
         Task<Result<List<Models.FileImportLog>>> GetFileImportLogs(Guid estateId, DateTime startDateTime, DateTime endDateTime, Guid? merchantId, CancellationToken cancellationToken);
 
         Task<Result<Models.FileImportLog>> GetFileImportLog(Guid fileImportLogId, Guid estateId, Guid? merchantId, CancellationToken cancellationToken);

FileProcessor.BusinessLogic/Managers/IFileProfileManager.cs

@@ -10,8 +10,6 @@ namespace FileProcessor.BusinessLogic.Managers;
 
 public interface IFileProfileManager
 {
-    Task<Result> EnsureSeededFileProfiles(CancellationToken cancellationToken);
-
     Task<Result<List<FileProfileModel>>> GetAllFileProfiles(CancellationToken cancellationToken);
 
     Task<Result<FileProfileModel>> GetFileProfile(Guid fileProfileId, CancellationToken cancellationToken);

FileProcessor.IntegrationTests/Features/FileProfile.feature

@@ -20,9 +20,9 @@ Background:
 
 Scenario: Create, update and list file profiles
 	When I create the following file profiles
-	| Alias | Name | ListeningDirectory | RequestType | OperatorName | LineTerminator | FileFormatHandler |
-	| Profile A | Profile A | /home/txnproc/bulkfiles/profile-a | ProfileARequest | Operator A | \n | ProfileAHandler |
-	| Profile B | Profile B | /home/txnproc/bulkfiles/profile-b | ProfileBRequest | Operator B | \r\n | ProfileBHandler |
+	| Alias | FileProfileId | Name | ListeningDirectory | RequestType | OperatorName | LineTerminator | FileFormatHandler |
+	| Profile A | 11111111-1111-1111-1111-111111111111 | Profile A | /home/txnproc/bulkfiles/profile-a | ProfileARequest | Operator A | \n | ProfileAHandler |
+	| Profile B | 22222222-2222-2222-2222-222222222222 | Profile B | /home/txnproc/bulkfiles/profile-b | ProfileBRequest | Operator B | \r\n | ProfileBHandler |
 	And I update the following file profiles
 	| Alias | Name | ListeningDirectory | RequestType | OperatorName | LineTerminator | FileFormatHandler |
 	| Profile A | Profile A Updated | /home/txnproc/bulkfiles/profile-a-updated | ProfileARequestUpdated | Operator A Updated | \r\n | ProfileAHandlerUpdated |
@@ -34,9 +34,9 @@ Scenario: Create, update and list file profiles
 
 Scenario: Reject duplicate file profile name and request type
 	When I create the following file profiles
-	| Alias | Name | ListeningDirectory | RequestType | OperatorName | LineTerminator | FileFormatHandler |
-	| Profile A | Profile A | /home/txnproc/bulkfiles/profile-a | ProfileARequest | Operator A | \n | ProfileAHandler |
-	| Profile B | Profile B | /home/txnproc/bulkfiles/profile-b | ProfileBRequest | Operator B | \r\n | ProfileBHandler |
+	| Alias | FileProfileId | Name | ListeningDirectory | RequestType | OperatorName | LineTerminator | FileFormatHandler |
+	| Profile A | 33333333-3333-3333-3333-333333333333 | Profile A | /home/txnproc/bulkfiles/profile-a | ProfileARequest | Operator A | \n | ProfileAHandler |
+	| Profile B | 44444444-4444-4444-4444-444444444444 | Profile B | /home/txnproc/bulkfiles/profile-b | ProfileBRequest | Operator B | \r\n | ProfileBHandler |
 	And I try to create the following duplicate file profiles
 	| DuplicateType | BasedOn |
 	| Name | Profile A |

FileProcessor.IntegrationTests/Features/FileProfileSteps.cs

@@ -33,13 +33,7 @@ public async Task WhenICreateTheFollowingFileProfiles(DataTable table)
         foreach (DataTableRow row in table.Rows)
         {
             string alias = row["Alias"];
-            CreateFileProfileRequest request = this.BuildCreateRequest(row);
-            Result<FileProfile> createResult = await this.FileProcessorSteps.CreateFileProfile(this.TestingContext.AccessToken, request, CancellationToken.None);
-
-            createResult.IsSuccess.ShouldBeTrue(createResult.Message);
-            createResult.Data.ShouldNotBeNull();
-
-            this.FileProfileIds[alias] = createResult.Data.FileProfileId;
+            await this.CreateProfile(alias, this.BuildCreateRequest(row));
         }
     }
 
@@ -126,7 +120,7 @@ private CreateFileProfileRequest BuildCreateRequest(DataTableRow row)
     {
         return new CreateFileProfileRequest
         {
-            FileProfileId = Guid.NewGuid(),
+            FileProfileId = Guid.Parse(row["FileProfileId"]),
             Name = row["Name"],
             ListeningDirectory = row["ListeningDirectory"],
             RequestType = row["RequestType"],
@@ -136,6 +130,16 @@ private CreateFileProfileRequest BuildCreateRequest(DataTableRow row)
         };
     }
 
+    private async Task CreateProfile(string alias, CreateFileProfileRequest request)
+    {
+        Result<FileProfile> createResult = await this.FileProcessorSteps.CreateFileProfile(this.TestingContext.AccessToken, request, CancellationToken.None);
+
+        createResult.IsSuccess.ShouldBeTrue(createResult.Message);
+        createResult.Data.ShouldNotBeNull();
+
+        this.FileProfileIds[alias] = createResult.Data.FileProfileId;
+    }
+
     private UpdateFileProfileRequest BuildUpdateRequest(DataTableRow row)
     {
         return new UpdateFileProfileRequest

FileProcessor.IntegrationTests/Features/GetFileImportDetails.feature

@@ -20,6 +20,11 @@ Background:
 	| ClientId      | 
 	| serviceClient | 
 
+	When I create the following file profiles
+	| Alias | FileProfileId | Name | ListeningDirectory | RequestType | OperatorName | LineTerminator | FileFormatHandler |
+	| Safaricom Topup | B2A59ABF-293D-4A6B-B81B-7007503C3476 | Safaricom Topup | /home/txnproc/bulkfiles/safaricom | SafaricomTopupRequest | Safaricom | \n | SafaricomFileFormatHandler |
+	| Voucher Issue | 8806EDBC-3ED6-406B-9E5F-A9078356BE99 | Voucher Issue | /home/txnproc/bulkfiles/voucher | VoucherRequest | Voucher | \n | VoucherFileFormatHandler |
+
 	Given I have created the following estates
 	| EstateName    |
 	| Test Estate 1 |
@@ -152,4 +157,4 @@ Scenario: Get File Import Log Details
 
 
 
-
+