Minor cmake refactor - #172
Open
SIN-Willett wants to merge 4 commits into
Open
Conversation
added 4 commits
January 10, 2022 16:57
find_package(libvterm REQUIRED) and target_link_libraries(target PRIVATE libvterm::vterm-static)
source files are not written out in duplicate
source files are not written out in duplicate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey I've been using this in a pet project of mine,
I was strugglling with installing/including it nicely in another cmake project so:
I've updated it so that the libraries can easily be acquired with find_package() using the cmake installation's default paths
It works on macOS with ncurses installed via homebrew.
I'm yet to test it out on linux/BSD/Windows, however the previous packaging system was left unchanged, so it shouldn't be any less portable.
I also put the demo into it's own CMakeLists.txt, as it felt right.