Repository navigation
fix(worldfinder): anchor Pause/Warp on the correct CMP in VR builds - #18
Merged
TrackAndTruckDevs merged 1 commit intoOct 6, 2026
Conversation
Owner
|
merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the Oculus/VR builds of ETS2 and ATS,
WorldDataFinderfails:Because
GlobalWarpOffsetis part of the readiness gate, this takes all ofGameWorldServiceoffline for those players (time, pause, halt, map scale, city data, coordinates…), not just the warp control. Reported across1.61.1.1001s,1.61.3.1001s,1.60.1.1007s, up to the latest framework release.Root cause
PAUSE_SIG(CMP byte [r64+off32], r8 ; JE) is not unique insideCoreEngine_UpdateLoop. The VR rebuild adds an earlier bool check of the same shape before the real pause test:Taking the first
PAUSE_SIGmatch anchors on0xbc8, so:PauseStatusOffsetresolves to a silently wrong value (0xbc8, non-zero → no error logged), andMOVSSsits ~280 bytes away, outside the 32-byte window →NOT FOUND.Standard builds don't have this extra VR check before the pause test, so their first match is the real one, which is why they were unaffected.
Fix
Pick the
PAUSE_SIGmatch that the Global WarpMOVSSactually follows (warp within 32 bytes), with a fallback to the first match. This corrects both the Pause anchor and the Warp read in one place.Verification
Validated against the real binaries (byte-level) and in-game:
1.61.1.1001sFAILED (75/76), Pause off0xbc8READY (77/77), Pause0xab1, Warp0x8acREADY (77/77)— no regressionThe new logic is identical to the old one whenever the first
PAUSE_SIGmatch already has a warp nearby (every previously-working build), so it cannot regress them.