Repository navigation
fix(notification): defer sound until first render - #15
Merged
TrackAndTruckDevs merged 1 commit intoOct 5, 2026
Merged
TrackAndTruckDevs merged 1 commit into
TrackAndTruckDevs merged 1 commit into
Conversation
Play the message sound from `RenderSingleNotification` instead of `ShowEx` so queued top notifications don't sound before they appear.
Owner
|
Thanks, merged. |
Contributor
Author
|
None, everything is good from SPF, just taking my time to release the new version, in some days. Thanks for asking! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When two or more plugins have an update available, the notification sound played several times in a row immediately, before the second popup appeared.
SPF_NOTIF_MODE_TOPdisplays only one notification at a time; the others wait in a queue. However,NotificationWindow::ShowExplayed the sound as soon as the notification was enqueued. With N queued TOP notifications, the sound fired N times at once, and the later popups then appeared silently.This affects any burst of TOP notifications (plugin update notices, framework update notice, plugin API calls).
Fix
pendingSoundflag toNotificationData.ShowExno longer plays the sound; it only setspendingSound(same condition as before: sound enabled and mode is not STICKY).RenderSingleNotificationplays the sound on the notification's first render and clears the flag. Since queued TOP notifications are not rendered until they become active, each one now plays its sound when it actually appears.STACK notifications are unaffected: they are rendered on the next frame, so their sound plays as before.