Update to 1.21.1 - #39
Open
cpaca wants to merge 83 commits into
Open
Conversation
ProtocolLib note: 5.2.0-SNAPSHOT wasn't working, so I just made it 5.4.0. I don't know what ProtocolLib is being used for, so I'm leaving it at this until we put more thought into it. Future commits will be about fixing all of the bugs (some things got removed/deprecated.)
"As of 1.20.5 enchantments do not have a rarity." https://jd.papermc.io/paper/1.21.8/org/bukkit/enchantments/Enchantment.html
It's been replaced with getActiveSlotGroups. From what I can tell, the function isn't used anyway, but it's here. I'm getting the vibe I should delete the whole file.
I might have removed too much, but from what I can tell, everything I removed was just added because it was required by the old class. I kept getCostMultiplier as it's used by AnvilListener, and lore as it's not @OverRide.
Not sure what it needs yet, but I do think it still needs to exist.
These will be defined by the datapack.
It's now managed by GradleUp.
enchantable items are getting their key using CustomItem's getKey(), which uses the plugin. This will be resolved in a future version, as Enchantable only exists on CustomItem objects, which (now) only exist to add one recipe each.
Doing this one early because I need it for another commit I wanna try.
Also makes backdash booklike.
cpaca
marked this pull request as ready for review
September 17, 2025 23:52
No longer being used.
Spawning 80 seems like too much though.
Apparantly I changed the privacy level when I reimplemented the recipe
Idea: What if we deleted the CustomEnchantment class?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.