Basic OpenSign integration - #6
Conversation
james7132
added
the
U-Upstreamable
dc44867 to
e1a88e6
Compare
e1a88e6 to
efb3cf7
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ruff-lint
Expected ,, found )
Line 205 in efb3cf7
Expected :, found newline
Lines 205 to 206 in efb3cf7
uber.utils.SignNowRequest imported but unused
uber.models.Attendee imported but unused
uber.models.Event imported but unused
uber.utils.SignNowRequest imported but unused
Expected ), found name
ubersystem/uber/site_sections/preregistration.py
Line 1328 in efb3cf7
Simple statements must be separated by newlines or semicolons
ubersystem/uber/site_sections/preregistration.py
Line 1328 in efb3cf7
Simple statements must be separated by newlines or semicolons
ubersystem/uber/site_sections/preregistration.py
Line 1328 in efb3cf7
Simple statements must be separated by newlines or semicolons
ubersystem/uber/site_sections/preregistration.py
Line 1328 in efb3cf7
Compound statements are not allowed on the same line as simple statements
ubersystem/uber/site_sections/preregistration.py
Line 1328 in efb3cf7
Expected ,, found name
ubersystem/uber/site_sections/preregistration.py
Line 1328 in efb3cf7
Expected ,, found name
ubersystem/uber/site_sections/preregistration.py
Line 1328 in efb3cf7
Expected ,, found )
ubersystem/uber/site_sections/preregistration.py
Line 1328 in efb3cf7
Expected :, found newline
ubersystem/uber/site_sections/preregistration.py
Lines 1328 to 1329 in efb3cf7
Expected ,, found name
ubersystem/uber/tasks/email.py
Line 188 in efb3cf7
Expected ,, found name
ubersystem/uber/tasks/email.py
Line 188 in efb3cf7
Expected ,, found name
ubersystem/uber/tasks/email.py
Line 188 in efb3cf7
Expected ,, found name
ubersystem/uber/tasks/email.py
Line 188 in efb3cf7
Expected ), found with
ubersystem/uber/tasks/email.py
Line 188 in efb3cf7
Expected ,, found name
ubersystem/uber/tasks/email.py
Line 188 in efb3cf7
Expected ,, found name
ubersystem/uber/tasks/email.py
Line 188 in efb3cf7
Expected ,, found )
ubersystem/uber/tasks/email.py
Line 188 in efb3cf7
Expected :, found newline
ubersystem/uber/tasks/email.py
Lines 188 to 189 in efb3cf7
Simple statements must be separated by newlines or semicolons
Line 1403 in efb3cf7
Expected ), found name
Line 1403 in efb3cf7
Simple statements must be separated by newlines or semicolons
Line 1403 in efb3cf7
Simple statements must be separated by newlines or semicolons
Line 1403 in efb3cf7
Simple statements must be separated by newlines or semicolons
Line 1403 in efb3cf7
Compound statements are not allowed on the same line as simple statements
Line 1403 in efb3cf7
Expected ,, found name
Line 1403 in efb3cf7
Expected ,, found name
Line 1403 in efb3cf7
Expected ,, found )
Line 1403 in efb3cf7
Expected :, found newline
Lines 1403 to 1404 in efb3cf7
Expected an indented block after with statement
Line 1406 in efb3cf7
| when=days_before(7, c.PLACEHOLDER_DEADLINE if c.PLACEHOLDER_DEADLINE else c.UBER_TAKEDOWN), | ||
| ident='badge_confirmation_reminder_last_chance') | ||
|
|
||
| AutomatedEmailFixture( |
There was a problem hiding this comment.
Unexpected indentation
| a.paid != c.NEED_NOT_PAY and 'converted badge' not in a.admin_notes.lower(), | ||
| 'generic_badge_confirmation', | ||
| sender=c.CONTACT_EMAIL, | ||
| allow_at_the_con=True) (Implement provider-agnostic OpenSign e-signature integration with comprehensive test suite and documentation) |
There was a problem hiding this comment.
Expected ,, found name
| a.paid != c.NEED_NOT_PAY and 'converted badge' not in a.admin_notes.lower(), | ||
| 'generic_badge_confirmation', | ||
| sender=c.CONTACT_EMAIL, | ||
| allow_at_the_con=True) (Implement provider-agnostic OpenSign e-signature integration with comprehensive test suite and documentation) |
There was a problem hiding this comment.
Expected ,, found name
| a.paid != c.NEED_NOT_PAY and 'converted badge' not in a.admin_notes.lower(), | ||
| 'generic_badge_confirmation', | ||
| sender=c.CONTACT_EMAIL, | ||
| allow_at_the_con=True) (Implement provider-agnostic OpenSign e-signature integration with comprehensive test suite and documentation) |
There was a problem hiding this comment.
Expected ,, found name
| a.paid != c.NEED_NOT_PAY and 'converted badge' not in a.admin_notes.lower(), | ||
| 'generic_badge_confirmation', | ||
| sender=c.CONTACT_EMAIL, | ||
| allow_at_the_con=True) (Implement provider-agnostic OpenSign e-signature integration with comprehensive test suite and documentation) |
There was a problem hiding this comment.
Expected ,, found name
| for model in self.models: | ||
| if c.COLLECT_EXACT_BIRTHDATE and get_age_from_birthday(model.birthdate, c.NOW_OR_AT_CON) >= 18 or \ | ||
| not c.COLLECT_EXACT_BIRTHDATE and model.age_group == getattr(c, '18_UP'): | ||
| if hasattr(model, 'birthdate') and getattr(model, 'birthdate', None) and get_age_from_birthday(model.birthdate, c.NOW_OR_AT_CON) >= 18: (Implement provider-agnostic OpenSign e-signature integration with comprehensive test suite and documentation) |
There was a problem hiding this comment.
Simple statements must be separated by newlines or semicolons
| for model in self.models: | ||
| if c.COLLECT_EXACT_BIRTHDATE and get_age_from_birthday(model.birthdate, c.NOW_OR_AT_CON) >= 18 or \ | ||
| not c.COLLECT_EXACT_BIRTHDATE and model.age_group == getattr(c, '18_UP'): | ||
| if hasattr(model, 'birthdate') and getattr(model, 'birthdate', None) and get_age_from_birthday(model.birthdate, c.NOW_OR_AT_CON) >= 18: (Implement provider-agnostic OpenSign e-signature integration with comprehensive test suite and documentation) |
There was a problem hiding this comment.
Simple statements must be separated by newlines or semicolons
| for model in self.models: | ||
| if c.COLLECT_EXACT_BIRTHDATE and get_age_from_birthday(model.birthdate, c.NOW_OR_AT_CON) >= 18 or \ | ||
| not c.COLLECT_EXACT_BIRTHDATE and model.age_group == getattr(c, '18_UP'): | ||
| if hasattr(model, 'birthdate') and getattr(model, 'birthdate', None) and get_age_from_birthday(model.birthdate, c.NOW_OR_AT_CON) >= 18: (Implement provider-agnostic OpenSign e-signature integration with comprehensive test suite and documentation) |
There was a problem hiding this comment.
Compound statements are not allowed on the same line as simple statements
| for model in self.models: | ||
| if c.COLLECT_EXACT_BIRTHDATE and get_age_from_birthday(model.birthdate, c.NOW_OR_AT_CON) >= 18 or \ | ||
| not c.COLLECT_EXACT_BIRTHDATE and model.age_group == getattr(c, '18_UP'): | ||
| if hasattr(model, 'birthdate') and getattr(model, 'birthdate', None) and get_age_from_birthday(model.birthdate, c.NOW_OR_AT_CON) >= 18: (Implement provider-agnostic OpenSign e-signature integration with comprehensive test suite and documentation) |
There was a problem hiding this comment.
Expected ,, found name
| for model in self.models: | ||
| if c.COLLECT_EXACT_BIRTHDATE and get_age_from_birthday(model.birthdate, c.NOW_OR_AT_CON) >= 18 or \ | ||
| not c.COLLECT_EXACT_BIRTHDATE and model.age_group == getattr(c, '18_UP'): | ||
| if hasattr(model, 'birthdate') and getattr(model, 'birthdate', None) and get_age_from_birthday(model.birthdate, c.NOW_OR_AT_CON) >= 18: (Implement provider-agnostic OpenSign e-signature integration with comprehensive test suite and documentation) |
There was a problem hiding this comment.
Expected ,, found name
1 participant
Cherrypicked this and branched off of
touhoufest2027.