Skip to content

fix: prune only matching release asset versions #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThunderTr77 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prune only matching release asset versions #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion apps/desktop/scripts/ci/plan-r2-release-asset-prune.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
githubRepositoryFromProduct,
isDownloadAssetName,
relativeUpdatePath,
versionFromAssetName,
} from '../update-release-assets.mjs';

const GITHUB_API_BASE_URL = 'https://api.github.com';
Expand Down Expand Up @@ -52,6 +53,10 @@ function githubHeaders(token) {
return headers;
}

function releaseVersionFromTag(tagName) {
return String(tagName ?? '').replace(/^v/u, '');
}

async function fetchGithubReleases(repository, fetchImpl, token) {
const releases = [];
for (let page = 1; page <= MAX_RELEASE_PAGES; page += 1) {
Expand Down Expand Up @@ -102,9 +107,14 @@ export async function planR2ReleaseAssetPrune(projectRoot, channel, options = {}
const keys = [];

for (const release of staleReleases) {
const releaseVersion = releaseVersionFromTag(release?.tag_name);
for (const asset of release.assets ?? []) {
const fileName = asset?.name;
if (!isDownloadAssetName(fileName) || channelFromAssetName(fileName) !== channel) {
if (
!isDownloadAssetName(fileName) ||
channelFromAssetName(fileName) !== channel ||
versionFromAssetName(fileName) !== releaseVersion
) {
continue;
}
keys.push(`${updatePath}/${fileName}`);
Expand Down
1 change: 1 addition & 0 deletions apps/desktop/tests/ci/plan-r2-release-asset-prune.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ describe('planR2ReleaseAssetPrune', () => {
release('v0.2.0-beta.2', '2026-05-22T00:00:00Z', [
'TouchAI-beta-0.2.0-beta.2-windows-full.nupkg',
'TouchAI-beta-0.2.0-beta.2-windows-delta.nupkg',
'TouchAI-beta-0.2.0-beta.20-windows-full.nupkg',
'release-notes.md',
]),
release('v0.2.0', '2026-05-21T00:00:00Z', ['TouchAI-0.2.0-windows-full.nupkg']),
Expand Down
Loading