Skip to content

fix(neighbors): partial pbc and imports#591

Merged
CompRhys merged 5 commits into
TorchSim:mainfrom
lil-lon:fix/neighbor-partial-pbc-and-imports
Jul 21, 2026
Merged

fix(neighbors): partial pbc and imports#591
CompRhys merged 5 commits into
TorchSim:mainfrom
lil-lon:fix/neighbor-partial-pbc-and-imports

Conversation

@lil-lon

@lil-lon lil-lon commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes #575, fixes a partial-pbc bug in vesin_nl, and updates import paths for current releases.

Bug fix

Import path fix and refactoring

  • Support the vesin-torch 0.6 module move (vesin.torch -> vesin_torch), keeping the old path as a fallback
  • Import nvalchemiops from its public path (nvalchemiops.torch.neighbors) and drop the legacy fallback

Test

  • Add partial-pbc slab tests and fold the dummy-cell molecule variants into the fixture for simplicity and test efficiency
  • codecov fails because no tests verify the package import behavior. If needed, I'd add corresponding tests

Checklist

Before a pull request can be merged, the following items must be checked:

  • Doc strings have been added in the Google docstring format.
  • Run ruff on your code.
  • Tests have been added for any new functionality or bug fixes.

@lil-lon lil-lon changed the title Fix/neighbor partial pbc and imports fix (neighbors): partial pbc and imports Jul 18, 2026
@lil-lon lil-lon changed the title fix (neighbors): partial pbc and imports fix(neighbors): partial pbc and imports Jul 18, 2026
@CompRhys

Copy link
Copy Markdown
Member

Thanks for the follow on PR, I am currently on holiday and will review/merge next week.

@CompRhys CompRhys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CompRhys
CompRhys merged commit 5c5a3a1 into TorchSim:main Jul 21, 2026
61 of 64 checks passed
@lil-lon
lil-lon deleted the fix/neighbor-partial-pbc-and-imports branch July 21, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Naive neighbor list is wrong for non-periodic systems carrying a cell

2 participants