Republish extension as universal - #8
Conversation
There was a problem hiding this comment.
Pull request overview
This PR repackages the extension as a standard (non-preview) universal Marketplace extension and adds an automated Marketplace release verification step to the stable and daily publishing workflows.
Changes:
- Removed preview Marketplace metadata and bumped extension version to
0.1.12. - Added a
scripts/verify-marketplace-release.mjsscript to poll Marketplace until a given version is visible and downloadable. - Updated the
release.ymlanddaily-release.ymlworkflows to run the new verification script after publishing.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
scripts/verify-marketplace-release.mjs |
New CLI script that checks Marketplace version/targets and verifies the vspackage endpoint is reachable. |
package.json |
Removes preview metadata, bumps version, and wires the verification script into npm scripts. |
package-lock.json |
Updates lockfile version fields to match the new extension version. |
.github/workflows/release.yml |
Replaces inline Marketplace polling with the new verification script for stable releases. |
.github/workflows/daily-release.yml |
Adds Marketplace verification after publishing the daily pre-release. |
Comments suppressed due to low confidence (1)
package.json:13
verify-marketplace-release.mjsrelies on the globalfetchAPI, which requires Node 18+ (and some environments still default to older Node). Sincepackage.jsondoesn’t currently declare a Node engine, consider adding anengines.nodeconstraint (e.g., ">=18") or switching the script to an explicitly imported fetch implementation so local/CI runs fail fast with a clear requirement.
"engines": {
"vscode": "^1.110.0"
},
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| .filter(Boolean); | ||
| const timeoutSeconds = Number(args.get('timeout-seconds') ?? '900'); | ||
| const pollSeconds = Number(args.get('poll-seconds') ?? '20'); | ||
|
|
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Summary
Verification