Biochemistry Examples#2
Open
paulflang wants to merge 17 commits into
Open
Conversation
213f88b to
93f7b71
Compare
964df70 to
1375e97
Compare
paulflang
commented
Jun 17, 2026
Comment on lines
+736
to
+744
| // @Evan: This shows the problem that the C is bound to the wrong A. It should be bound to the A that is bound to B. | ||
| // let bond [] in | ||
| // let bond_AB [] in | ||
| // ( | ||
| // A [e_ha [], e_Ca [], 0.0], | ||
| // A [e_ha [], 1.1, e_ta []], | ||
| // B [0.1, 1.2, e_tb []], | ||
| // C [1.0] | ||
| // ) |
Collaborator
Author
There was a problem hiding this comment.
I think we need emergent sites for this, as described here: https://github.com/ToposInstitute/sys-bio-collab/pull/15
This would make sure that C-binding ability emerges from A-to-B dimerization.
paulflang
commented
Jun 17, 2026
| // ( | ||
| // (M [iota_B], M [iota_SiteA [0.0]]), | ||
| // ((M [iota_A], M [iota_SiteB 0.1], M [iota_Res phos []]), (M [iota_K])) | ||
| // ) |
Collaborator
Author
There was a problem hiding this comment.
I think the problem is that (M [iota_B], M [iota_SiteA [0.0]]) is not indecomposable. To generate indecomposable agents from monomers, we'd need something like emergent sites and species, as described here: https://github.com/ToposInstitute/sys-bio-collab/pull/15
Collaborator
Author
|
@epatters any thoughts on the last two comments? Otherwise I believe this is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds examples from
After merging this PR and #1 , it might make sense to create a separate file to store all example models.
The following lists a few characteristics, learnings and TODOs (not for this PR) about each example:
toy_model_species_granularity
is inspired by examples 1 and 3 here. It tests:
ReMonomer)[])ReBvs.ReB1andReB2)Learnings:
PatTm::Tensors, which we cannot restrict viaPatTm::res, IIUC. Instead, we use the.substmethod to replace a partial restriction with a "longer" composite restriction..clone. This is a bit unergonomic, but will be obsolete once models can be parsed from bare text.toy_model_emergent_agent
PatTm::Let)Open questions:
R_dimerizationcan be restricted.R_trimerizationalready lives in[]. Yet, there are weird nameless transitions like this one generated, that also containR_dimerization. Why is that?toy_model_directionality
C).Personal learnings on notation:
s1ands2)"id_"or"1". This helps to distinguish them from (non-trivial) restrictions.TODO:
R_AtoB_dimerizationis of type[head, Site_C, Site_C, tail]. Starting from only monomers, this should lead to the same reachable states as if the type were[head, tail], since there is no rule producingACandBCdimers (remark: this is just for experimentation. In practice, rules should not rely on reachability assumptions and be specified in the most restrictive way possible, to minimize unintended side-effects (esp. when knowledge from different authors is combined) and computational complexity). Test if this is true, once we can restrict to reachable states.toy_model_phospho_tyrosine
tests:
[])[].Learnings