Skip to content

fix(scripts): make lint globs PowerShell-safe - #78

Merged
TonyCasey merged 1 commit into
mainfrom
GIT-118
Feb 15, 2026
Merged

fix(scripts): make lint globs PowerShell-safe#78
TonyCasey merged 1 commit into
mainfrom
GIT-118

Conversation

@TonyCasey

@TonyCasey TonyCasey commented Feb 15, 2026

Copy link
Copy Markdown
Owner

Summary

  • fix(scripts): make lint globs PowerShell-safe (GIT-118)

Summary by CodeRabbit

  • Chores
    • Updated build script configuration. No user-visible changes.

Copilot AI review requested due to automatic review settings February 15, 2026 22:20
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Feb 15, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

The lint and lint:fix scripts in package.json were updated to use escaped double quotes around glob patterns instead of the previous quoting style, maintaining identical command functionality.

Changes

Cohort / File(s) Summary
Package Configuration
package.json
Updated lint and lint:fix script arguments to use escaped double quotes around glob patterns; no functional change to command execution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Merge Conflict Detection ⚠️ Warning ❌ Merge conflicts detected (3 files):

⚔️ package.json (content)
⚔️ src/commands/init.ts (content)
⚔️ tests/unit/commands/init.test.ts (content)

These conflicts must be resolved before merging into main.
Resolve conflicts locally and push changes to this branch.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: making lint glob patterns PowerShell-safe by escaping quotes in package.json scripts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch GIT-118
⚔️ Resolve merge conflicts (beta)
  • Auto-commit resolved conflicts to branch GIT-118
  • Create stacked PR with resolved conflicts
  • Post resolved changes as copyable diffs in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes PowerShell compatibility for the lint scripts by changing glob pattern quotes from single to double quotes. PowerShell treats single-quoted glob patterns as literal strings rather than expandable patterns, which prevents the lint scripts from working correctly on Windows with PowerShell.

Changes:

  • Updated lint and lint:fix scripts to use double quotes instead of single quotes for the glob pattern src/**/*.{ts,js}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@TonyCasey
TonyCasey merged commit 1d10ffc into main Feb 15, 2026
9 checks passed
@TonyCasey
TonyCasey deleted the GIT-118 branch February 15, 2026 22:44
@TonyCasey
TonyCasey restored the GIT-118 branch February 15, 2026 22:48
@TonyCasey
TonyCasey deleted the GIT-118 branch February 15, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants