fix: show longer ingredient names in recipe ingredient cards#1103
Open
Percy2Live wants to merge 1 commit into
Open
fix: show longer ingredient names in recipe ingredient cards#1103Percy2Live wants to merge 1 commit into
Percy2Live wants to merge 1 commit into
Conversation
Increase maxLines for the title in SelectableButtonCard from 2 to 3 so longer ingredient names are fully visible in recipe ingredient cards without truncation. Also wrap the title in a Tooltip so the full name is accessible on hover/long-press, and reduce description maxLines to 1 to give the title more vertical space. Fixes TomBursch#1102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the Android app, recipe ingredient cards currently truncate longer ingredient names after too little text. In some cases there is no way to see the full ingredient name from the recipe detail screen, which makes the ingredient ambiguous.
Example from a recipe ingredient grid:
HENGLEIN Mini-Knödel halb&hal...→1 Packungvegane Mini-Frikadellen (ca. ...→1 PackungSince the full name is not visible, it is unclear which exact product or ingredient is needed.
Fix
Increase
maxLinesfor the title inSelectableButtonCardfrom 2 to 3, so longer ingredient names are fully visible in recipe ingredient cards without truncation. Also:Tooltipso the full name is accessible on hover/long-pressmaxLinesfrom 2 to 1 to give the title more vertical space within the square grid cardThis makes the recipe overview more useful without requiring users to edit the recipe or guess the missing ingredient name.
Fixes #1102