Adding aria label to unread notification icon - #156
Adding aria label to unread notification icon#156karthikktamilmani-freshworks wants to merge 1 commit into
Conversation
neilmispelaar
left a comment
neilmispelaar
left a comment
There was a problem hiding this comment.
Hi Karthikk,
ReadNotification.vue:
The <i> tag has semantic meaning so I can't recommend it's use in this particular case.
Would be much better to use a <span> or <div> element here.
InboxItem
Will approve but would ask that maybe we can take a moment to explain what's going on exactly.
Thank you! Looking great.
TishamIslam
left a comment
TishamIslam
left a comment
There was a problem hiding this comment.
Hi Karthikk, I believe what's meant for this task is to provide not just hidden text indicating that there's an unread message but to also provide visible text for sighted users that may not understand the significance of the blue icon.
"Many users may have difficulties determining the meaning of this icon based on the colour alone." implies that the Accessibility team wants us to account for sighted users and not just users using screenreaders.
3 participants
VA-76
Providing proper text description for unread notification icon