fix(release): host SVG loader for flatpak export's icon validation - #40
Merged
Conversation
Export validates the app icon with the host's gdk-pixbuf, not the sandbox's; without librsvg2-common the scalable icon fails as format not recognized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt 5: everything passed except the Flatpak, which reached its final stage.
flatpak build-exportvalidates the app icons using the host's gdk-pixbuf loaders, not the sandbox's, and the job's--no-install-recommendsinstall leaves the runner without the SVG loader, so the scalable icon fails with "Format not recognized".librsvg2-commonadded to the job's packages.Export is the last stage before build-bundle; nothing runs after it but the artifact upload. Same follow-up: retag 0.1.0 on the merge commit.