Add packaging icon assets and wire CMake install rules - #11
Merged
Conversation
dish.desktop already declared Icon=dish, but the package shipped no matching icon file — desktop environments fell back to a generic glyph. This adds the v5 dish icon (512x512 PNG + scalable SVG) under packaging/ and installs: - packaging/dish.desktop -> share/applications/ - packaging/dish.png -> share/pixmaps/ - packaging/dish.svg -> share/icons/hicolor/scalable/apps/ so app menus, the GNOME/KDE dash, and Wayland window-list previews all pick up the correct launcher icon.
The exports-v5 dish source picked up a wider mask cut-out under the dish stand. Re-render packaging/dish.png and refresh the canonical packaging/dish.svg to match.
Matches the originals' transparent canvas. Desktop environments already paint their own panel/dash background behind the icon, so the tile was redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dishlauncher icon topackaging/as both a 512×512 PNG and a scalable SVG.dish.desktop,dish.png, anddish.svgto the standard FreeDesktop paths via CMake.dish.desktopdeclaredIcon=dishbut no matching file was packaged, so app menus rendered a generic glyph.Test plan
cmake -S . -B build && cmake --build build && DESTDIR=/tmp/dish-stage cmake --install build/tmp/dish-stage/usr/share/pixmaps/dish.pngand/tmp/dish-stage/usr/share/icons/hicolor/scalable/apps/dish.svg