Doc: Enum Clarifications and Additions - #29
Draft
Zoroark-Zwart wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The premise of this suggestion is to make enum explanations in the help docs clearer, more precise and give obvious callouts about where to find all available enum values. This suggestion also aims to hopefully keep enum value names untranslated by showing them in backtick quotes ` where they are helpful to keep untranslated.
Suggestion thread: https://discord.com/channels/988081966035402783/1506800529706193079
Pull Request (PR)
The PR is in draft mode because it requires additional translations.
Hats Missing from Home
There is no Hats category on the home page. This would be helpful to have in order for players to know which hats they have unlocked easily, just like any other enum.
While I could add the code tags for this to the PR, I could not generate them. The markdown for this should be something like:
And having it after the Grounds category would probably make sense.
If this category is added, I would also suggest adding this:
To the end of
@code_tooltip_change_hatincode_tooltipsMeasure More Info Clause
The
measurepage has a section for related pages that is either outdated or non-inclusive.Currently, this is what it says:
But it should probably say this if you have all of the related unlocks:
This seems to be a generated message based on unlock permissions during code run. So I could add a request via the
code_tooltipsfile.Other Measure Issues
As a side note,
measureshould be available for use for all measurable crops, but it doesn't seem to be usable for pumpkins when you unlock them. It would also be nice ifmeasurewere usable when either of these is available:Whenever either of those unlocks is purchased.